Additional CI fixes.

Author: tychedelia

.github/actions/setup/action.yml

@@ -0,0 +1,18 @@
+name: 'Setup Build Environment'
+description: 'Install system dependencies and Rust toolchain'
+inputs:
+  components:
+    description: 'Rust components to install'
+    required: false
+    default: ''
+runs:
+  using: 'composite'
+  steps:
+    - name: Install system dependencies
+      run: sudo apt-get update && sudo apt-get install -y g++ pkg-config libx11-dev libasound2-dev libudev-dev libxkbcommon-x11-0 libwayland-dev libxkbcommon-dev libglfw3-dev
+      shell: bash
+
+    - name: Install Rust
+      uses: dtolnay/rust-toolchain@stable
+      with:
+        components: ${{ inputs.components }}

.github/workflows/ci.yml

@@ -16,8 +16,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
+      - uses: ./.github/actions/setup
 
       - name: Cache cargo registry
         uses: actions/cache@v4
@@ -46,8 +45,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
+      - uses: ./.github/actions/setup
         with:
           components: rustfmt
 
@@ -60,8 +58,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
+      - uses: ./.github/actions/setup
         with:
           components: clippy
 
@@ -92,8 +89,7 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
-      - name: Install Rust
-        uses: dtolnay/rust-toolchain@stable
+      - uses: ./.github/actions/setup
 
       - name: Cache cargo registry
         uses: actions/cache@v4

Cargo.toml

@@ -3,10 +3,17 @@ name = "processing"
 version = "0.1.0"
 edition = "2024"
 
+[lints]
+workspace = true
+
 [workspace]
 resolver = "3"
 members = ["crates/*"]
 
+[workspace.lints.clippy]
+type_complexity = "allow"
+too_many_arguments = "allow"
+
 [workspace.dependencies]
 bevy = { version = "0.17", no-default-features = true, features = [
     "bevy_render",

crates/processing_ffi/Cargo.toml

@@ -3,6 +3,9 @@ name = "processing_ffi"
 version = "0.1.0"
 edition = "2024"
 
+[lints]
+workspace = true
+
 [lib]
 name = "processing"
 crate-type = ["cdylib"]

crates/processing_ffi/src/error.rs

@@ -7,7 +7,7 @@ use std::{
 use processing::prelude::error::ProcessingError;
 
 thread_local! {
-    static LAST_ERROR: RefCell<Option<CString>> = RefCell::new(None);
+    static LAST_ERROR: RefCell<Option<CString>> = const { RefCell::new(None) };
 }
 
 /// Check if the last operation resulted in an error. Returns a pointer to an error message, or null

crates/processing_ffi/src/lib.rs

@@ -1,5 +1,6 @@
 use bevy::prelude::Entity;
 use processing::prelude::*;
+
 use crate::color::Color;
 
 mod color;
@@ -13,7 +14,7 @@ mod error;
 #[unsafe(no_mangle)]
 pub extern "C" fn processing_init() {
     error::clear_error();
-    error::check(|| init());
+    error::check(init);
 }
 
 /// Create a WebGPU surface from a native window handle.
@@ -33,7 +34,7 @@ pub extern "C" fn processing_create_surface(
     scale_factor: f32,
 ) -> u64 {
     error::clear_error();
-    error::check(|| create_surface(window_handle, width, height, scale_factor))
+    error::check(|| create_surface(window_handle, display_handle, width, height, scale_factor))
         .map(|e| e.to_bits())
         .unwrap_or(0)
 }

crates/processing_render/Cargo.toml

@@ -3,6 +3,9 @@ name = "processing_render"
 version = "0.1.0"
 edition = "2024"
 
+[lints]
+workspace = true
+
 [dependencies]
 bevy = { workspace = true }
 lyon = "1.0"

crates/processing_render/src/lib.rs

@@ -27,7 +27,7 @@ use crate::{
 static IS_INIT: OnceLock<()> = OnceLock::new();
 
 thread_local! {
-    static APP: RefCell<Option<App>> = RefCell::new(None);
+    static APP: RefCell<Option<App>> = const { RefCell::new(None) };
 }
 
 #[derive(Resource, Default)]
@@ -64,7 +64,7 @@ impl CameraProjection for ProcessingProjection {
             0.0,
             self.width,
             self.height, // bottom = height
-            0.0, // top = 0
+            0.0,         // top = 0
             self.near,
             self.far,
         )
@@ -94,36 +94,25 @@ impl CameraProjection for ProcessingProjection {
 
         [
             // near plane
-            near_center + Vec3A::new(half_width, half_height, 0.0),   // bottom-right
-            near_center + Vec3A::new(half_width, -half_height, 0.0),  // top-right
+            near_center + Vec3A::new(half_width, half_height, 0.0), // bottom-right
+            near_center + Vec3A::new(half_width, -half_height, 0.0), // top-right
             near_center + Vec3A::new(-half_width, -half_height, 0.0), // top-left
-            near_center + Vec3A::new(-half_width, half_height, 0.0),  // bottom-left
+            near_center + Vec3A::new(-half_width, half_height, 0.0), // bottom-left
             // far plane
-            far_center + Vec3A::new(half_width, half_height, 0.0),    // bottom-right
-            far_center + Vec3A::new(half_width, -half_height, 0.0),   // top-right
-            far_center + Vec3A::new(-half_width, -half_height, 0.0),  // top-left
-            far_center + Vec3A::new(-half_width, half_height, 0.0),   // bottom-left
+            far_center + Vec3A::new(half_width, half_height, 0.0), // bottom-right
+            far_center + Vec3A::new(half_width, -half_height, 0.0), // top-right
+            far_center + Vec3A::new(-half_width, -half_height, 0.0), // top-left
+            far_center + Vec3A::new(-half_width, half_height, 0.0), // bottom-left
         ]
     }
 }
 
-fn app<T>(cb: impl FnOnce(&App) -> Result<T>) -> Result<T> {
-    let res = APP.with(|app_cell| {
-        let app_borrow = app_cell.borrow();
-        let app = app_borrow
-            .as_ref()
-            .ok_or_else(|| error::ProcessingError::AppAccess)?;
-        cb(app)
-    })?;
-    Ok(res)
-}
-
 fn app_mut<T>(cb: impl FnOnce(&mut App) -> Result<T>) -> Result<T> {
     let res = APP.with(|app_cell| {
         let mut app_borrow = app_cell.borrow_mut();
         let app = app_borrow
             .as_mut()
-            .ok_or_else(|| error::ProcessingError::AppAccess)?;
+            .ok_or(error::ProcessingError::AppAccess)?;
         cb(app)
     })?;
     Ok(res)
@@ -195,10 +184,7 @@ pub fn create_surface(
             let content_view: Option<Retained<NSView>> = ns_window_ref.contentView();
 
             match content_view {
-                Some(view) => {
-                    let view_ptr = Retained::as_ptr(&view) as *mut std::ffi::c_void;
-                    view_ptr
-                }
+                Some(view) => Retained::as_ptr(&view) as *mut std::ffi::c_void,
                 None => {
                     return Err(error::ProcessingError::InvalidWindowHandle);
                 }
@@ -215,10 +201,10 @@ pub fn create_surface(
 
     #[cfg(target_os = "windows")]
     let (raw_window_handle, raw_display_handle) = {
-        use raw_window_handle::{Win32WindowHandle, WindowsDisplayHandle};
         use std::num::NonZeroIsize;
-        use windows::Win32::Foundation::HINSTANCE;
-        use windows::Win32::System::LibraryLoader::GetModuleHandleW;
+
+        use raw_window_handle::{Win32WindowHandle, WindowsDisplayHandle};
+        use windows::Win32::{Foundation::HINSTANCE, System::LibraryLoader::GetModuleHandleW};
 
         if window_handle == 0 {
             return Err(error::ProcessingError::InvalidWindowHandle);
@@ -478,7 +464,6 @@ pub fn exit(exit_code: u8) -> Result<()> {
         Ok(())
     })?;
 
-
     // we need to drop the app in a deterministic manner to ensure resourcse are cleaned up
     // otherwise we'll get wgpu graphics backend errors on exit
     APP.with(|app_cell| {
@@ -492,7 +477,7 @@ pub fn exit(exit_code: u8) -> Result<()> {
 pub fn background_color(window_entity: Entity, color: Color) -> Result<()> {
     app_mut(|app| {
         let mut camera_query = app.world_mut().query::<(&mut Camera, &ChildOf)>();
-        for (mut camera, parent) in camera_query.iter_mut(&mut app.world_mut()) {
+        for (mut camera, parent) in camera_query.iter_mut(app.world_mut()) {
             if parent.parent() == window_entity {
                 camera.clear_color = ClearColorConfig::Custom(color);
             }

crates/processing_render/src/render/primitive/rect.rs

@@ -101,11 +101,11 @@ fn simple_rect(mesh: &mut Mesh, x: f32, y: f32, w: f32, h: f32, color: Color) {
     }
 
     if let Some(Indices::U32(indices)) = mesh.indices_mut() {
-        indices.push(base_idx + 0);
+        indices.push(base_idx);
         indices.push(base_idx + 1);
         indices.push(base_idx + 2);
 
-        indices.push(base_idx + 0);
+        indices.push(base_idx);
         indices.push(base_idx + 2);
         indices.push(base_idx + 3);
     }

examples/glfw.rs

@@ -22,7 +22,11 @@ impl GlfwContext {
         window.set_all_polling(true);
         window.show();
 
-        Ok(Self { glfw, window, events })
+        Ok(Self {
+            glfw,
+            window,
+            events,
+        })
     }
 
     #[cfg(target_os = "macos")]