Merge pull request #4 from therewasaguy/jvntf-synths

jvntf · web-flow · commit 0f4887c7a533 · 2017-08-21T15:25:22.000-07:00
upgrade tone / use getValueAtTime to fix polysynth voicesInUse
diff --git a/package.json b/package.json
@@ -19,6 +19,6 @@
     "grunt-open": "^0.2.3"
   },
   "dependencies": {
-    "tone": "therewasaguy/tone.js#p5-dev"
+    "tone": "0.10.0"
   }
 }
diff --git a/src/polysynth.js b/src/polysynth.js
@@ -193,8 +193,8 @@ define(function (require) {
     }
 
 
-    if(this._voicesInUse.value < this.polyValue) {
-      currentVoice = this._voicesInUse.value;
+    if(this._voicesInUse.getValueAtTime(t) < this.polyValue) {
+      currentVoice = this._voicesInUse.getValueAtTime(t);
     } else {
       currentVoice = this._oldest;
 

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,6 @@`
`19`	`19`	`"grunt-open": "^0.2.3"`
`20`	`20`	`},`
`21`	`21`	`"dependencies": {`
`22`		`- "tone": "therewasaguy/tone.js#p5-dev"`
	`22`	`+ "tone": "0.10.0"`
`23`	`23`	`}`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -193,8 +193,8 @@ define(function (require) {`
`193`	`193`	`}`
`194`	`194`
`195`	`195`
`196`		`- if(this._voicesInUse.value < this.polyValue) {`
`197`		`- currentVoice = this._voicesInUse.value;`
	`196`	`+ if(this._voicesInUse.getValueAtTime(t) < this.polyValue) {`
	`197`	`+ currentVoice = this._voicesInUse.getValueAtTime(t);`
`198`	`198`	`} else {`
`199`	`199`	`currentVoice = this._oldest;`
`200`	`200`