pulse tweakin

Author: therewasaguy

lib/p5.sound.js

@@ -2896,6 +2896,7 @@ pulse = function () {
    */
   p5.Pulse = function (freq, w) {
     p5.Oscillator.call(this, freq, 'sawtooth');
+    this.output.disconnect();
     // width of PWM, should be betw 0 to 1.0
     this.w = w || 0;
     // create a second oscillator with inverse frequency
@@ -2908,8 +2909,9 @@ pulse = function () {
     this.dcOffset.connect(this.dcGain);
     this.dcGain.connect(this.output);
     // set delay time based on PWM width
-    var mW = this.w / this.oscillator.frequency.value;
-    this.dNode.delayTime.setValueAtTime(mW, p5sound.audiocontext.currentTime);
+    this.f = freq || 440;
+    var mW = map(this.w, 0, 1, 0, 1 / this.f);
+    this.dNode.delayTime.value = mW;
     this.dcGain.gain.value = 1.7 * (0.5 - this.w);
     this.oscillator.disconnect();
     this.newGain = p5sound.audiocontext.createGain();
@@ -2920,9 +2922,9 @@ pulse = function () {
     this.osc2.disconnect();
     this.osc2.output.gain.minValue = -10;
     this.osc2.output.gain.maxValue = 10;
-    this.osc2.output.gain.value = -1;
+    this.osc2.amp(-1);
     // inverted amplitude
-    this.osc2.panner.connect(this.dNode);
+    this.osc2.output.connect(this.dNode);
     this.dNode.connect(this.output);
     this.output.connect(this.panner);
   };
@@ -2939,8 +2941,10 @@ pulse = function () {
     if (w <= 1 && w >= 0) {
       this.w = w;
       // set delay time based on PWM width
-      var mW = this.w / this.oscillator.frequency.value;
-      this.dNode.delayTime.setValueAtTime(mW, p5sound.audiocontext.currentTime);
+      // var mW = map(this.w, 0, 1.0, 0, 1/this.f);
+      var mW = this.w / this.f;
+      console.log(mW);
+      this.dNode.delayTime.value = mW;
     }
     this.dcGain.gain.value = 1.7 * (0.5 - this.w);
   };
@@ -2967,6 +2971,8 @@ pulse = function () {
         this.osc2.oscillator.frequency
       ];
       // start dcOffset, too
+      this.dcOffset = createDCOffset();
+      this.dcOffset.connect(this.dcGain);
       this.dcOffset.start(t + now);
       // if LFO connections depend on these oscillators
       if (this.mods !== undefined && this.mods.frequency !== undefined) {