Fix memory leak in Reverb. (#651)

GHSam · web-flow · commit 1a9beda85280 · 2021-12-09T13:44:06.000-08:00
Disconnects convolver node from input so it can be GC'd.
diff --git a/src/reverb.js b/src/reverb.js
@@ -78,6 +78,7 @@ class Reverb extends Effect {
 
   _teardownConvolverNode() {
     if (this.convolverNode) {
+      this.input.disconnect(this.convolverNode);
       this.convolverNode.disconnect();
       delete this.convolverNode;
     }

Original file line number	Diff line number	Diff line change
`@@ -78,6 +78,7 @@ class Reverb extends Effect {`
`78`	`78`
`79`	`79`	`_teardownConvolverNode() {`
`80`	`80`	`if (this.convolverNode) {`
	`81`	`+ this.input.disconnect(this.convolverNode);`
`81`	`82`	`this.convolverNode.disconnect();`
`82`	`83`	`delete this.convolverNode;`
`83`	`84`	`}`