Merge pull request #636 from satyasaibhushan/adding-tests-for-covered-files

(Gsoc'21) (Week-6,7)Adding tests for covered files

Author: Guillermo Montecinos

src/amplitude.js

@@ -184,9 +184,10 @@ class Amplitude {
       } else {
         this.output.connect(unit);
       }
-    } else {
-      this.output.connect(this.panner.connect(p5sound.input));
     }
+    // else {
+    //   this.output.connect(this.panner.connect(p5sound.input));
+    // }
   }
 
   disconnect() {

src/audioin.js

@@ -237,7 +237,7 @@ class AudioIn {
    */
   getLevel(smoothing) {
     if (smoothing) {
-      this.amplitude.smoothing = smoothing;
+      this.amplitude.smooth(smoothing);
     }
     return this.amplitude.getLevel();
   }

src/eq.js

@@ -166,7 +166,7 @@ class EQ extends Effect {
         this.bands[i / 2].gain(arguments[i + 1]);
       }
     } else {
-      console.error(
+      throw new Error(
         'Argument mismatch. .set() should be called with ' +
           this.bands.length * 2 +
           ' arguments. (one frequency and gain value pair for each band of the eq)'

src/fft.js

@@ -171,13 +171,12 @@ class FFT {
    *
    */
   waveform() {
-    var bins, mode;
+    var mode;
     var normalArray = new Array();
 
     for (var i = 0; i < arguments.length; i++) {
       if (typeof arguments[i] === 'number') {
-        bins = arguments[i];
-        this.analyser.fftSize = bins * 2;
+        this.bins = arguments[i];
       }
       if (typeof arguments[i] === 'string') {
         mode = arguments[i];
@@ -275,7 +274,6 @@ class FFT {
     for (var i = 0; i < arguments.length; i++) {
       if (typeof arguments[i] === 'number') {
         this.bins = arguments[i];
-        this.analyser.fftSize = this.bins * 2;
       }
       if (typeof arguments[i] === 'string') {
         mode = arguments[i];

src/helpers.js

@@ -149,7 +149,9 @@ function soundFormats() {
 }
 
 function disposeSound() {
-  for (var i = 0; i < p5sound.soundArray.length; i++) {
+  //looping backwards as looping forward may cause the
+  //index of an element to change while the loop runs
+  for (var i = p5sound.soundArray.length - 1; i >= 0; i--) {
     p5sound.soundArray[i].dispose();
   }
 }

test/testAudio/bx-spring.mp3

@@ -26,5 +26,6 @@ import('./tests/p5.Pulse.js');
 import('./tests/p5.Noise.js');
 import('./tests/p5.Panner.js');
 import('./tests/p5.Panner3d.js');
-import('./tests/p5.Listener3d.js');
+import('./tests/p5.Delay.js');
 import('./tests/p5.Reverb.js');
+import('./tests/p5.Listener3d.js');

test/testAudio/bx-spring.ogg

@@ -1,10 +1,36 @@
 const expect = chai.expect;
 describe('main output', function () {
+  it('can initiate main class', function () {
+    expect(p5.soundOut.input).to.have.property('gain');
+    expect(p5.soundOut.input).to.have.property('context');
+    expect(p5.soundOut.output).to.have.property('gain');
+    expect(p5.soundOut.output).to.have.property('context');
+    expect(p5.soundOut.limiter.threshold.value).to.equal(-3);
+    expect(p5.soundOut.limiter.ratio.value).to.equal(20);
+    expect(p5.soundOut.limiter.knee.value).to.equal(1);
+    expect(p5.soundOut.audiocontext).to.have.property('audioWorklet');
+    expect(p5.soundOut.audiocontext).to.have.property('baseLatency');
+    expect(p5.soundOut.meter).to.have.property('gain');
+    expect(p5.soundOut.meter).to.have.property('context');
+    expect(p5.soundOut.fftMeter).to.have.property('gain');
+    expect(p5.soundOut.fftMeter).to.have.property('context');
+    expect(p5.soundOut.soundArray).to.be.an('array');
+    expect(p5.soundOut.parts).to.be.an('array');
+    expect(p5.soundOut.extensions).to.be.an('array');
+
+    expect(p5.soundOut._silentNode).to.have.property('gain');
+    expect(p5.soundOut._silentNode).to.have.property('context');
+    expect(p5.soundOut._silentNode.gain.value).to.equal(0);
+
+    console.log(p5.soundOut);
+  });
+
   it('can set and return output volume', function (done) {
     p5.prototype.outputVolume(0.6);
 
     setTimeout(function () {
-      expect(p5.prototype.getOutputVolume()).to.be.closeTo(0.6, 0.05);
+      expect(p5.prototype.getOutputVolume()).to.be.approximately(0.6, 0.05);
+      expect(p5.prototype.outputVolume().value).to.be.approximately(0.6, 0.05);
       done();
     }, 100);
   });
@@ -13,7 +39,7 @@ describe('main output', function () {
     p5.prototype.outputVolume(0.9, 0, t);
 
     setTimeout(function () {
-      expect(p5.prototype.getOutputVolume()).to.be.closeTo(0.9, 0.05);
+      expect(p5.prototype.getOutputVolume()).to.be.approximately(0.9, 0.05);
       done();
     }, 1100);
   });
@@ -23,8 +49,13 @@ describe('main output', function () {
     p5.prototype.outputVolume(1, t, 0);
 
     setTimeout(function () {
-      expect(p5.prototype.getOutputVolume()).to.be.closeTo(0.5, 0.5);
+      expect(p5.prototype.getOutputVolume()).to.be.approximately(0.5, 0.5);
       done();
     }, 500);
   });
+
+  it('can connect an audio node to p5sound output', function () {
+    let noise = new p5.Noise();
+    p5.prototype.outputVolume(noise);
+  });
 });

test/tests.js

@@ -3,61 +3,120 @@ const expect = chai.expect;
 describe('p5.Amplitude', function () {
   this.timeout(1000);
 
-  let sf, amp, osc, oAmp;
+  let amp;
+  let osc = new p5.Oscillator('square');
+  osc.amp(1);
+  osc.start();
+  osc.disconnect();
 
-  it('can be created', function () {
+  beforeEach(function () {
     amp = new p5.Amplitude();
   });
 
+  it('can be created', function () {
+    expect(amp).to.have.property('audiocontext').not.be.null;
+    expect(amp).to.have.property('_workletNode').not.be.null;
+    expect(amp.bufferSize).to.equal(2048);
+    expect(amp).to.have.property('input');
+    expect(amp).to.have.property('output');
+    expect(amp.volume).to.equal(0);
+    expect(amp.volNorm).to.equal(0);
+    expect(amp.stereoVol).to.deep.equal([0, 0]);
+    expect(amp.stereoVolNorm).to.deep.equal([0, 0]);
+  });
+
   after(function (done) {
-    expect(amp.getLevel()).to.not.equal(1.0);
     osc.dispose();
-    sf.dispose();
     done();
   });
-
-  it('accepts oscillator input', function () {
-    osc = new p5.Oscillator('square');
-    osc.amp(1);
-    osc.start();
-    osc.disconnect();
-    oAmp = new p5.Amplitude();
-    oAmp.setInput(osc);
+  it('can be created with smoothing', function () {
+    new p5.Amplitude(0.02);
   });
 
-  it('gets oscillator level', function () {
-    setTimeout(function () {
-      // console.log( 'unnormalized: ' + oAmp.getLevel() );
-      expect(oAmp.getLevel()).to.be.closeTo(0.55, 0.25);
-    }, 100);
-  });
+  describe('methods', function () {
+    it('accepts oscillator input', function () {
+      amp.setInput(osc);
+    });
+    it('setInput connects to main output if no argument is passed', function () {
+      amp.setInput();
+    });
 
-  it('gets normalized osc level', function (done) {
-    setTimeout(function () {
-      oAmp.toggleNormalize(true);
-      // console.log( 'normalized: ' + oAmp.getLevel() );
-      expect(oAmp.getLevel()).to.be.closeTo(1.0, 0.4);
-      done();
-    }, 200);
-  });
+    it('can be connected and disconnected from a unit', function () {
+      let filter = new p5.Filter();
+
+      //if unit has input property
+      amp.connect(filter);
+      amp.disconnect();
+
+      //if unit doesnot have an input property
+      amp = new p5.Amplitude();
+      amp.connect(filter.input);
+      amp.disconnect();
+
+      filter.dispose();
+    });
+
+    it('can toggle normalization', function () {
+      expect(amp.normalize).to.be.false;
+      amp.toggleNormalize();
+      expect(amp.normalize).to.be.true;
+
+      amp.toggleNormalize(true);
+      expect(amp.normalize).to.be.true;
+      amp.toggleNormalize(false);
+      expect(amp.normalize).to.be.false;
+    });
 
-  it('loop a SoundFile with params, disconnected from master, setInput()', function (done) {
-    p5.prototype.soundFormats('ogg', 'mp3');
-    sf = p5.prototype.loadSound('./testAudio/drum', function () {
-      sf.disconnect();
-      sf.loop(1, 1, 0.0, 0.05);
-      sf.connect(amp);
+    it('gets oscillator level', function () {
+      amp.setInput(osc);
       setTimeout(function () {
-        done();
+        expect(amp.getLevel()).to.be.closeTo(0.55, 0.25);
       }, 100);
     });
-  });
 
-  it('stop getting level', function (done) {
-    sf.stop();
-    setTimeout(function () {
-      // console.log( amp.getLevel() );
-      done();
-    }, 10);
+    it('gets normalized osc level', function (done) {
+      amp.setInput(osc);
+      setTimeout(function () {
+        amp.toggleNormalize(true);
+        expect(amp.getLevel()).to.be.closeTo(1.0, 0.4);
+        done();
+      }, 200);
+    });
+    it('gets stereo osc level', function (done) {
+      amp.setInput(osc);
+      setTimeout(function () {
+        expect(amp.getLevel(0)).to.be.closeTo(0.55, 0.25);
+        expect(amp.getLevel(1)).to.be.closeTo(0.55, 0.25);
+        amp.toggleNormalize(true);
+        expect(amp.getLevel(0)).to.be.closeTo(1, 0.4);
+        expect(amp.getLevel(1)).to.be.closeTo(1, 0.4);
+        done();
+      }, 200);
+    });
+
+    it('can be connected to a soundFile', function (done) {
+      p5.prototype.soundFormats('ogg', 'mp3');
+      let sf = p5.prototype.loadSound('./testAudio/drum', function () {
+        sf.disconnect();
+        sf.loop(1, 1, 0.0, 0.05);
+        sf.connect(amp);
+        sf.dispose();
+        setTimeout(function () {
+          sf.stop();
+          done();
+        }, 100);
+      });
+    });
+
+    it('can apply smoothing', function () {
+      amp.smooth(0.5);
+    });
+
+    it('can be disposed', function () {
+      amp.dispose();
+      expect(amp).to.not.have.property('input');
+      expect(amp).to.not.have.property('output');
+      expect(amp).to.not.have.property('_workletNode');
+    });
   });
 });