Merge pull request #626 from satyasaibhushan/improving-tests-Gsoc

(Gsoc'21) (Week-1) Fixes broken tests

Author: satyasaibhushan

.eslintrc

@@ -34,7 +34,7 @@
 
   },
   "parserOptions": {
-    "ecmaVersion": 6,
+    "ecmaVersion": 8,
     "sourceType": "module",
     "allowImportExportEverywhere": true
     }

lib/p5.sound.js

@@ -91,7 +91,7 @@ class SoundRecorder {
     this._inputChannels = 2;
     this._outputChannels = 2; // stereo output, even if input is mono
 
-    const workletBufferSize = safeBufferSize(1024);
+    const workletBufferSize = (this.bufferSize = safeBufferSize(1024));
 
     this._workletNode = new AudioWorkletNode(
       ac,

lib/p5.sound.js.map

@@ -36,22 +36,30 @@ describe('p5.EQ', function () {
     expect(eq.bands[2].biquad.type).to.equal('peaking');
   });
 
-  it('a bands gain value can be changed', function () {
+  it("a band's gain value can be changed", function () {
     const eq = new p5.EQ(8);
     expect(eq.bands[2].gain()).to.equal(0);
     eq.bands[2].gain(30);
     expect(eq.bands[2].gain()).to.equal(30);
   });
 
-  it('a bands freq value can be changed', function () {
+  it('a band has correct default value', function () {
+    const eq = new p5.EQ(8);
+    setTimeout(() => {
+      expect(eq.bands[0].freq()).to.equal(100);
+    }, 100);
+  });
+
+  it("a band's freq value can be changed", function () {
     const eq = new p5.EQ(8);
-    expect(eq.bands[0].freq()).to.equal(100);
     eq.bands[0].freq(200);
-    expect(eq.bands[0].gain()).to.equal(0);
-    expect(eq.bands[0].freq()).to.equal(200);
+    setTimeout(() => {
+      expect(eq.bands[0].gain()).to.equal(0);
+      expect(eq.bands[0].freq()).to.equal(200);
+    }, 100);
   });
 
-  it('a bands type can be changed', function () {
+  it("a band's type can be changed", function () {
     const eq = new p5.EQ();
     expect(eq.bands[2]._untoggledType).to.equal('peaking');
     eq.bands[2].setType('highshelf');

lib/p5.sound.min.js

@@ -8,12 +8,12 @@ describe('Testing helpers function', function () {
 
   it('p5.prototype.midiToFreq helper function', function () {
     const freq = p5.prototype.midiToFreq(100);
-    expect(freq).to.equal(2637.0204553029594);
+    expect(freq).to.be.approximately(2637.0204553029594, 0.00000000001);
   });
 
   it('p5.prototype.noteToFreq helper function', function () {
     const freq = p5.prototype.noteToFreq('C4');
-    expect(freq).to.equal(261.6255653005986);
+    expect(freq).to.be.approximately(261.6255653005986, 0.00000000001);
   });
 
   it('p5.prototype.soundFormats helper function', function () {

lib/p5.sound.min.js.map

@@ -15,6 +15,6 @@ describe('p5.MonoSynth', function () {
       expect(monoSynth.oscillator.freq().value).to.equal(110);
       monoSynth.dispose();
       done();
-    }, 1);
+    }, 10);
   });
 });

src/soundRecorder.js

@@ -12,20 +12,20 @@ describe('p5.PolySynth', function () {
     const polySynth = new p5.PolySynth();
     const noteDuration = 0.01;
 
-    const noteTriggerTime = audioContext.currentTime;
-    const noteActiveTime = noteTriggerTime + noteDuration / 2;
-    const noteDoneTime = noteTriggerTime + noteDuration;
+    const getTriggerTime = () => audioContext.currentTime;
+    const getActiveTime = () => getTriggerTime() + noteDuration / 2;
+    const getDoneTime = () => getTriggerTime() + noteDuration;
 
-    expect(polySynth._voicesInUse.getValueAtTime(noteTriggerTime)).to.equal(0);
+    expect(polySynth._voicesInUse.getValueAtTime(getTriggerTime())).to.equal(0);
 
     polySynth.play('A2', 0, 0, noteDuration);
-    expect(polySynth._voicesInUse.getValueAtTime(noteActiveTime)).to.equal(1);
+    expect(polySynth._voicesInUse.getValueAtTime(getActiveTime())).to.equal(1);
     polySynth.play('A3', 0, 0, noteDuration);
-    expect(polySynth._voicesInUse.getValueAtTime(noteActiveTime)).to.equal(2);
+    expect(polySynth._voicesInUse.getValueAtTime(getActiveTime())).to.equal(2);
     polySynth.play('A4', 0, 0, noteDuration);
-    expect(polySynth._voicesInUse.getValueAtTime(noteActiveTime)).to.equal(3);
+    expect(polySynth._voicesInUse.getValueAtTime(getActiveTime())).to.equal(3);
 
-    expect(polySynth._voicesInUse.getValueAtTime(noteDoneTime)).to.equal(0);
+    expect(polySynth._voicesInUse.getValueAtTime(getDoneTime())).to.equal(0);
 
     polySynth.dispose();
   });