Skip to content

Commit 5002d0a

Browse files
(Gsoc'21)🔨Fixes a bug in reverb.js,added it to test list
1 parent 1db3db8 commit 5002d0a

File tree

2 files changed

+2
-14
lines changed

2 files changed

+2
-14
lines changed

src/reverb.js

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -103,20 +103,7 @@ class Reverb extends Effect {
103103
*/
104104
process(src, seconds, decayRate, reverse) {
105105
src.connect(this.input);
106-
var rebuild = false;
107-
if (seconds) {
108-
this._seconds = seconds;
109-
rebuild = true;
110-
}
111-
if (decayRate) {
112-
this._decay = decayRate;
113-
}
114-
if (reverse) {
115-
this._reverse = reverse;
116-
}
117-
if (rebuild) {
118-
this._buildImpulse();
119-
}
106+
this.set(seconds, decayRate, reverse);
120107
}
121108

122109
/**

test/tests.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,4 @@ import('./tests/p5.SoundRecorder.js');
1414
import('./tests/p5.SoundFile.js');
1515
import('./tests/p5.Amplitude.js');
1616
import('./tests/p5.Oscillator.js');
17+
import('./tests/p5.Reverb.js');

0 commit comments

Comments
 (0)