(Gsoc'21)🔨Corrects broken tests part-1

Author: satyasaibhushan

lib/p5.sound.js

@@ -387,7 +387,7 @@ class Score {
   constructor() {
     // for all of the arguments
     this.parts = [];
-    this.currentPart = new Array(arguments.length);;
+    this.currentPart = new Array(arguments.length);
 
     var thisScore = this;
     for (var i in arguments) {
@@ -396,7 +396,7 @@ class Score {
       this.parts[i].onended = function () {
         thisScore.resetPart(i);
         playNextPart(thisScore);
-      };    
+      };
     }
     this.looping = false;
   }

lib/p5.sound.js.map

@@ -88,7 +88,7 @@ class SoundRecorder {
     this._inputChannels = 2;
     this._outputChannels = 2; // stereo output, even if input is mono
 
-    const workletBufferSize = safeBufferSize(1024);
+    const workletBufferSize = (this.bufferSize = safeBufferSize(1024));
 
     this._workletNode = new AudioWorkletNode(
       ac,

lib/p5.sound.min.js

@@ -36,22 +36,30 @@ describe('p5.EQ', function () {
     expect(eq.bands[2].biquad.type).to.equal('peaking');
   });
 
-  it('a bands gain value can be changed', function () {
+  it("a band's gain value can be changed", function () {
     const eq = new p5.EQ(8);
     expect(eq.bands[2].gain()).to.equal(0);
     eq.bands[2].gain(30);
     expect(eq.bands[2].gain()).to.equal(30);
   });
 
-  it('a bands freq value can be changed', function () {
+  it('a band has correct default value', function () {
+    const eq = new p5.EQ(8);
+    setTimeout(() => {
+      expect(eq.bands[0].freq()).to.equal(100);
+    }, 100);
+  });
+
+  it("a band's freq value can be changed", function () {
     const eq = new p5.EQ(8);
-    expect(eq.bands[0].freq()).to.equal(100);
     eq.bands[0].freq(200);
-    expect(eq.bands[0].gain()).to.equal(0);
-    expect(eq.bands[0].freq()).to.equal(200);
+    setTimeout(() => {
+      expect(eq.bands[0].gain()).to.equal(0);
+      expect(eq.bands[0].freq()).to.equal(200);
+    }, 100);
   });
 
-  it('a bands type can be changed', function () {
+  it("a band's type can be changed", function () {
     const eq = new p5.EQ();
     expect(eq.bands[2]._untoggledType).to.equal('peaking');
     eq.bands[2].setType('highshelf');

lib/p5.sound.min.js.map

@@ -53,18 +53,21 @@ describe('p5.SoundRecorder', function () {
 
     const mic = new p5.AudioIn();
     mic.start(function () {
+      recorder.setInput(mic);
       const outputSoundFile = new p5.SoundFile();
-      recorder.record(outputSoundFile, recordingDuration, function () {
-        expect(outputSoundFile.duration()).to.eq(recordingDuration);
-
-        const outputChannel = outputSoundFile.buffer.getChannelData(0);
-        expect(outputChannel[0]).to.not.eq(0);
-
-        outputSoundFile.dispose();
-        mic.dispose();
-        p5.prototype.outputVolume(0);
-        done();
-      });
+      setTimeout(() => {
+        recorder.record(outputSoundFile, recordingDuration, function () {
+          expect(outputSoundFile.duration()).to.eq(recordingDuration);
+
+          const outputChannel = outputSoundFile.buffer.getChannelData(0);
+          expect(outputChannel[0]).to.not.eq(0);
+
+          outputSoundFile.dispose();
+          mic.dispose();
+          p5.prototype.outputVolume(0);
+          done();
+        });
+      }, 100);
     });
   });
 
@@ -106,16 +109,18 @@ describe('p5.SoundRecorder', function () {
     inputSoundFile.connect();
     inputSoundFile.loop();
     recorder.setInput();
-    recorder.record(outputSoundFile, recordingDuration, function () {
-      expect(outputSoundFile.duration()).to.eq(recordingDuration);
+    setTimeout(() => {
+      recorder.record(outputSoundFile, recordingDuration, function () {
+        expect(outputSoundFile.duration()).to.eq(recordingDuration);
 
-      const outputChannel = outputSoundFile.buffer.getChannelData(0);
-      expect(outputChannel[0]).to.not.eq(0);
+        const outputChannel = outputSoundFile.buffer.getChannelData(0);
+        expect(outputChannel[0]).to.not.eq(0);
 
-      outputSoundFile.dispose();
-      p5.prototype.outputVolume(0);
-      done();
-    });
+        outputSoundFile.dispose();
+        p5.prototype.outputVolume(0);
+        done();
+      });
+    }, 10);
   });
 
   it('can save a recorded buffer to a .wav file', function (done) {