Skip to content

Commit 6e30d73

Browse files
authored
Merge pull request #698 from KevinGrajeda/effects-doc-fixes
fix inconsistency in documentation of effects
2 parents 5bad8cb + 6fab553 commit 6e30d73

File tree

5 files changed

+15
-3
lines changed

5 files changed

+15
-3
lines changed

src/delay.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ class Delay extends Effect {
114114
*
115115
* @method process
116116
* @for p5.Delay
117-
* @param {Object} Signal An object that outputs audio
117+
* @param {Object} src An object that outputs audio
118118
* @param {Number} [delayTime] Time (in seconds) of the delay/echo.
119119
* Some browsers limit delayTime to
120120
* 1 second.

src/effect.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ import CrossFade from 'Tone/component/CrossFade.js';
1111
* <a href="/reference/#/p5.Compressor">p5.Compressor</a>,
1212
* <a href="/reference/#/p5.Delay">p5.Delay</a>,
1313
* <a href="/reference/#/p5.Filter">p5.Filter</a>,
14-
* <a href="/reference/#/p5.Reverb">p5.Reverb</a>.
14+
* <a href="/reference/#/p5.Reverb">p5.Reverb</a>,
15+
* <a href="/reference/#/p5.EQ">p5.EQ</a>,
16+
* <a href="/reference/#/p5.Panner3D">p5.Panner3D</a>.
1517
*
1618
* @class p5.Effect
1719
* @constructor

src/filter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ class Filter extends Effect {
112112
* of filter parameters.
113113
*
114114
* @method process
115-
* @param {Object} Signal An object that outputs audio
115+
* @param {Object} src An object that outputs audio
116116
* @param {Number} [freq] Frequency in Hz, from 10 to 22050
117117
* @param {Number} [res] Resonance/Width of the filter frequency
118118
* from 0.001 to 1000

src/panner3d.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,13 @@ import Effect from './effect';
1212
* Audio Context Listener</a>, which can be accessed
1313
* by <code>p5.soundOut.audiocontext.listener</code>
1414
*
15+
* This class extends <a href = "/reference/#/p5.Effect">p5.Effect</a>.
16+
* Methods <a href = "/reference/#/p5.Effect/amp">amp()</a>, <a href = "/reference/#/p5.Effect/chain">chain()</a>,
17+
* <a href = "/reference/#/p5.Effect/drywet">drywet()</a>, <a href = "/reference/#/p5.Effect/connect">connect()</a>, and
18+
* <a href = "/reference/#/p5.Effect/disconnect">disconnect()</a> are available.
1519
*
1620
* @class p5.Panner3D
21+
* @extends p5.Effect
1722
* @constructor
1823
*/
1924

src/reverb.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,11 @@ class Reverb extends Effect {
212212
* <p>Use the method <code>createConvolution(path)</code> to instantiate a
213213
* p5.Convolver with a path to your impulse response audio file.</p>
214214
*
215+
* This class extends <a href = "/reference/#/p5.Effect">p5.Effect</a>.
216+
* Methods <a href = "/reference/#/p5.Effect/amp">amp()</a>, <a href = "/reference/#/p5.Effect/chain">chain()</a>,
217+
* <a href = "/reference/#/p5.Effect/drywet">drywet()</a>, <a href = "/reference/#/p5.Effect/connect">connect()</a>, and
218+
* <a href = "/reference/#/p5.Effect/disconnect">disconnect()</a> are available.
219+
*
215220
* @class p5.Convolver
216221
* @extends p5.Effect
217222
* @constructor

0 commit comments

Comments
 (0)