Merge branch 'main' of https://github.com/processing/p5.js-sound into improving-tests-Gsoc

satyasaibhushan · satyasaibhushan · commit 6f2d824fb87f · 2021-06-17T15:25:05.000+05:30
diff --git a/src/helpers.js b/src/helpers.js
@@ -86,7 +86,7 @@ function noteToFreq(note) {
   if (typeof note !== 'string') {
     return note;
   }
-  var wholeNotes = { A: 21, B: 23, C: 24, D: 26, E: 28, F: 29, G: 31 };
+  var wholeNotes = { A: 33, B: 35, C: 24, D: 26, E: 28, F: 29, G: 31 };
   var value = wholeNotes[note[0].toUpperCase()];
   var octave = ~~note.slice(-1);
   value += 12 * (octave - 1);
diff --git a/src/polysynth.js b/src/polysynth.js
@@ -149,7 +149,7 @@ class PolySynth {
    *  }
    *  </code></div>
    */
-  play(note, velocity, secondsFromNow, susTime = 1) {
+  play(note, velocity = 0.1, secondsFromNow = 0, susTime = 1) {
     this.noteAttack(note, velocity, secondsFromNow);
     this.noteRelease(note, secondsFromNow + susTime);
   }

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ function noteToFreq(note) {`
`86`	`86`	`if (typeof note !== 'string') {`
`87`	`87`	`return note;`
`88`	`88`	`}`
`89`		`- var wholeNotes = { A: 21, B: 23, C: 24, D: 26, E: 28, F: 29, G: 31 };`
	`89`	`+ var wholeNotes = { A: 33, B: 35, C: 24, D: 26, E: 28, F: 29, G: 31 };`
`90`	`90`	`var value = wholeNotes[note[0].toUpperCase()];`
`91`	`91`	`var octave = ~~note.slice(-1);`
`92`	`92`	`value += 12 * (octave - 1);`
Original file line number	Diff line number	Diff line change
`@@ -149,7 +149,7 @@ class PolySynth {`
`149`	`149`	`* }`
`150`	`150`	`* </code></div>`
`151`	`151`	`*/`
`152`		`- play(note, velocity, secondsFromNow, susTime = 1) {`
	`152`	`+ play(note, velocity = 0.1, secondsFromNow = 0, susTime = 1) {`
`153`	`153`	`this.noteAttack(note, velocity, secondsFromNow);`
`154`	`154`	`this.noteRelease(note, secondsFromNow + susTime);`
`155`	`155`	`}`