Skip to content

Commit ae8867a

Browse files
authored
p5.Effect: Fix drywet function bug (#606)
1 parent 431d438 commit ae8867a

File tree

5 files changed

+12
-7
lines changed

5 files changed

+12
-7
lines changed

lib/p5.sound.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
/** [p5.sound] Version: 1.0.0 - 2021-03-04 */
1+
/** [p5.sound] Version: 1.0.0 - 2021-04-19 */
22
/**
33
* <p>p5.sound extends p5 with <a href="http://caniuse.com/audio-api"
44
* target="_blank">Web Audio</a> functionality including audio input,
@@ -1180,6 +1180,7 @@ var CustomError = function CustomError(name, errorTrace, failedPath) {
11801180

11811181
var moduleSources = [__webpack_require__(27)["default"], __webpack_require__(28)["default"], __webpack_require__(29)["default"]];
11821182
var audioWorklet_ac = master.audiocontext;
1183+
var initializedAudioWorklets = false;
11831184

11841185
function loadAudioWorkletModules() {
11851186
return Promise.all(moduleSources.map(function (moduleSrc) {
@@ -1192,6 +1193,8 @@ function loadAudioWorkletModules() {
11921193
}
11931194

11941195
p5.prototype.registerMethod('init', function () {
1196+
if (initializedAudioWorklets) return;
1197+
11951198
if (!this.preload && !window.preload) {
11961199
this.preload = function () {};
11971200
}
@@ -1200,6 +1203,8 @@ p5.prototype.registerMethod('init', function () {
12001203
this._incrementPreload();
12011204

12021205
var onWorkletModulesLoad = function () {
1206+
initializedAudioWorklets = true;
1207+
12031208
this._decrementPreload();
12041209
}.bind(this);
12051210

@@ -6527,7 +6532,7 @@ function () {
65276532

65286533
}, {
65296534
key: "drywet",
6530-
value: function drywet() {
6535+
value: function drywet(fade) {
65316536
if (typeof fade !== 'undefined') {
65326537
this._drywet.fade.value = fade;
65336538
}

lib/p5.sound.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/p5.sound.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/p5.sound.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/effect.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ class Effect {
101101
* @for p5.Effect
102102
* @param {Number} [fade] The desired drywet value (0 - 1.0)
103103
*/
104-
drywet() {
104+
drywet(fade) {
105105
if (typeof fade !== 'undefined') {
106106
this._drywet.fade.value = fade;
107107
}

0 commit comments

Comments
 (0)