Skip to content

Commit 234c4ff

Browse files
committed
🐛 fix broken useState
1 parent 627cfbf commit 234c4ff

File tree

1 file changed

+14
-8
lines changed

1 file changed

+14
-8
lines changed

client/modules/IDE/components/Console.jsx

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -83,29 +83,35 @@ const getConsoleFeedStyle = (theme, times, fontSize) => {
8383
}
8484
};
8585

86-
// 1 . FIXME: Object is not a function 🤷🏻
8786
const Console = () => {
8887
const consoleEvents = useSelector(state => state.console);
8988
const isExpanded = useSelector(state => state.ide.consoleIsExpanded);
9089
const { theme, fontSize } = useSelector(state => state.preferences);
9190

92-
const [cm, setCm] = useState({});
93-
94-
// 2. FIXME: Console is not opening/closing, and I suspect it has to do with this
95-
useDidUpdate(() => { if (cm) cm.scrollTop = cm.scrollHeight; });
96-
9791
const {
9892
collapseConsole, expandConsole, clearConsole, dispatchConsoleEvent
9993
} = bindActionCreators({ ...IDEActions, ...ConsoleActions }, useDispatch());
10094

10195
useDidUpdate(() => {
10296
clearConsole();
10397
dispatchConsoleEvent(consoleEvents);
104-
}, [theme, fontSize]);
98+
}, [theme, fontSize]); //
10599

106100
// const [consoleMessages, setConsoleMessages] = useState({});
107101
// this.consoleMessages.scrollTop = this.consoleMessages.scrollHeight;
108102

103+
// const clearConsole = () => {};
104+
// const collapseConsole = () => {};
105+
// const expandConsole = () => {};
106+
107+
// const isExpanded = true;
108+
// const fontSize = 16;
109+
// const theme = {};
110+
111+
// // 2. FIXME: Console is not opening/closing, and I suspect it has to do with this
112+
const cm = useRef({});
113+
useDidUpdate(() => { if (cm.current) cm.current.scrollTop = cm.current.scrollHeight; });
114+
109115

110116
const consoleClass = classNames({
111117
'preview-console': true,
@@ -132,7 +138,7 @@ const Console = () => {
132138
</button>
133139
</div>
134140
</header>
135-
<div ref={element => setCm(element)} className="preview-console__messages">
141+
<div ref={cm} className="preview-console__messages">
136142
{consoleEvents.map((consoleEvent) => {
137143
const { method, times } = consoleEvent;
138144
return (

0 commit comments

Comments
 (0)