Skip to content

Commit 2c917a2

Browse files
committed
Convert editor file to functional
1 parent c1102d9 commit 2c917a2

File tree

3 files changed

+305
-245
lines changed

3 files changed

+305
-245
lines changed

client/modules/IDE/components/Editor/codemirror.js

Lines changed: 33 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -93,12 +93,26 @@ function setupCodeMirrorHooks(
9393

9494
export default function setupCodeMirror(
9595
container,
96-
props,
96+
{
97+
theme,
98+
lineNumbers,
99+
linewrap,
100+
autocloseBracketsQuotes,
101+
setUnsavedChanges,
102+
hideRuntimeErrorWarning,
103+
updateFileContent,
104+
file,
105+
autorefresh,
106+
isPlaying,
107+
clearConsole,
108+
startSketch,
109+
autocompleteHinter,
110+
fontSize
111+
},
97112
onUpdateLinting,
98113
docs,
99114
updateLineNumber
100115
) {
101-
const { theme, lineNumbers, linewrap, autocloseBracketsQuotes } = props;
102116
const cm = CodeMirror(container, {
103117
theme: `p5-${theme}`,
104118
lineNumbers,
@@ -167,9 +181,24 @@ export default function setupCodeMirror(
167181
[`${metaKey}-.`]: 'toggleComment' // Note: most adblockers use the shortcut ctrl+.
168182
});
169183

170-
setupCodeMirrorHooks(cm, props, updateLineNumber);
184+
setupCodeMirrorHooks(
185+
cm,
186+
{
187+
setUnsavedChanges,
188+
hideRuntimeErrorWarning,
189+
updateFileContent,
190+
file,
191+
autorefresh,
192+
isPlaying,
193+
clearConsole,
194+
startSketch,
195+
autocompleteHinter,
196+
fontSize
197+
},
198+
updateLineNumber
199+
);
171200

172-
cm.swapDoc(docs[props.file.id]);
201+
cm.swapDoc(docs[file.id]);
173202

174203
return cm;
175204
}

0 commit comments

Comments
 (0)