Skip to content

Commit 2ce36be

Browse files
committed
Update UX of Quick Add List: when clicking on row/hovering on row, can add/remove sketch/collection
1 parent 1ef4b66 commit 2ce36be

File tree

2 files changed

+21
-7
lines changed

2 files changed

+21
-7
lines changed

client/modules/IDE/components/QuickAddList/QuickAddList.jsx

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,19 @@ import Icons from './Icons';
77
const Item = ({
88
isAdded, onSelect, name, url
99
}) => (
10-
<li className="quick-add__item">
10+
<li className="quick-add__item" onClick={onSelect}> { /* eslint-disable-line */ }
1111
<button className="quick-add__item-toggle" onClick={onSelect}>
1212
<Icons isAdded={isAdded} />
13-
{name}
1413
</button>
15-
<Link className="quick-add__item-view" to={url}>View</Link>
14+
<span className="quick-add__item-name">{name}</span>
15+
<Link
16+
className="quick-add__item-view"
17+
to={url}
18+
target="_blank"
19+
onClick={e => e.stopPropogation()}
20+
>
21+
View
22+
</Link>
1623
</li>
1724
);
1825

@@ -45,7 +52,10 @@ const QuickAddList = ({
4552
key={item.id}
4653
{...item}
4754
onSelect={
48-
() => handleAction(item)
55+
(event) => {
56+
event.target.blur();
57+
handleAction(item);
58+
}
4959
}
5060
/>))}
5161
</ul>

client/styles/components/_quick-add.scss

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@
2929
.quick-add__item-toggle {
3030
display: flex;
3131
align-items: center;
32+
}
3233

34+
.quick-add__item-name {
3335
flex: 1;
3436
}
3537

@@ -83,8 +85,10 @@
8385
transform: rotate(45deg);
8486
}
8587

88+
.quick-add__item:hover,
8689
.quick-add__item-toggle:hover,
8790
.quick-add__item-toggle:focus {
91+
cursor: pointer;
8892
@include themify() {
8993
.quick-add__icon {
9094
polygon {
@@ -97,11 +101,11 @@
97101
}
98102
}
99103

100-
.quick-add__in-icon {
104+
& .quick-add__in-icon {
101105
display: none;
102106
}
103107

104-
.quick-add__icon--in-collection {
108+
& .quick-add__icon--in-collection {
105109
.quick-add__remove-icon {
106110
display: inline-block;
107111
}
@@ -111,7 +115,7 @@
111115
}
112116
}
113117

114-
.quick-add__icon--not-in-collection {
118+
& .quick-add__icon--not-in-collection {
115119
.quick-add__add-icon {
116120
display: inline-block;
117121
}

0 commit comments

Comments
 (0)