Skip to content

Commit 410ef1b

Browse files
committed
♻️ dry up <IDEView />
1 parent f9fdadb commit 410ef1b

File tree

1 file changed

+16
-74
lines changed

1 file changed

+16
-74
lines changed

client/modules/IDE/pages/IDEView.jsx

Lines changed: 16 additions & 74 deletions
Original file line numberDiff line numberDiff line change
@@ -344,46 +344,7 @@ class IDEView extends React.Component {
344344
allowResize={this.props.ide.consoleIsExpanded}
345345
className="editor-preview-subpanel"
346346
>
347-
<Editor
348-
lintWarning={this.props.preferences.lintWarning}
349-
linewrap={this.props.preferences.linewrap}
350-
lintMessages={this.props.editorAccessibility.lintMessages}
351-
updateLintMessage={this.props.updateLintMessage}
352-
clearLintMessage={this.props.clearLintMessage}
353-
file={this.props.selectedFile}
354-
updateFileContent={this.props.updateFileContent}
355-
fontSize={this.props.preferences.fontSize}
356-
lineNumbers={this.props.preferences.lineNumbers}
357-
files={this.props.files}
358-
editorOptionsVisible={this.props.ide.editorOptionsVisible}
359-
showEditorOptions={this.props.showEditorOptions}
360-
closeEditorOptions={this.props.closeEditorOptions}
361-
showKeyboardShortcutModal={
362-
this.props.showKeyboardShortcutModal
363-
}
364-
setUnsavedChanges={this.props.setUnsavedChanges}
365-
isPlaying={this.props.ide.isPlaying}
366-
theme={this.props.preferences.theme}
367-
startRefreshSketch={this.props.startRefreshSketch}
368-
stopSketch={this.props.stopSketch}
369-
autorefresh={this.props.preferences.autorefresh}
370-
unsavedChanges={this.props.ide.unsavedChanges}
371-
projectSavedTime={this.props.project.updatedAt}
372-
isExpanded={this.props.ide.sidebarIsExpanded}
373-
expandSidebar={this.props.expandSidebar}
374-
collapseSidebar={this.props.collapseSidebar}
375-
isUserOwner={isUserOwner(this.props)}
376-
clearConsole={this.props.clearConsole}
377-
consoleEvents={this.props.console}
378-
showRuntimeErrorWarning={this.props.showRuntimeErrorWarning}
379-
hideRuntimeErrorWarning={this.props.hideRuntimeErrorWarning}
380-
runtimeErrorWarningVisible={
381-
this.props.ide.runtimeErrorWarningVisible
382-
}
383-
provideController={(ctl) => {
384-
this.cmController = ctl;
385-
}}
386-
/>
347+
<Editor provideController={(ctl) => { this.cmController = ctl; }} />
387348
<Console />
388349
</SplitPane>
389350
<section className="preview-frame-holder">
@@ -533,31 +494,25 @@ IDEView.propTypes = {
533494
}).isRequired,
534495
saveProject: PropTypes.func.isRequired,
535496
ide: PropTypes.shape({
536-
isPlaying: PropTypes.bool.isRequired,
537-
isAccessibleOutputPlaying: PropTypes.bool.isRequired,
538-
consoleEvent: PropTypes.array, // eslint-disable-line
539-
modalIsVisible: PropTypes.bool.isRequired,
540-
sidebarIsExpanded: PropTypes.bool.isRequired,
541-
consoleIsExpanded: PropTypes.bool.isRequired,
542-
preferencesIsVisible: PropTypes.bool.isRequired,
543-
projectOptionsVisible: PropTypes.bool.isRequired,
544-
newFolderModalVisible: PropTypes.bool.isRequired,
497+
errorType: PropTypes.string,
498+
keyboardShortcutVisible: PropTypes.bool.isRequired,
545499
shareModalVisible: PropTypes.bool.isRequired,
546500
shareModalProjectId: PropTypes.string.isRequired,
547501
shareModalProjectName: PropTypes.string.isRequired,
548502
shareModalProjectUsername: PropTypes.string.isRequired,
549-
editorOptionsVisible: PropTypes.bool.isRequired,
550-
keyboardShortcutVisible: PropTypes.bool.isRequired,
551-
unsavedChanges: PropTypes.bool.isRequired,
552-
infiniteLoop: PropTypes.bool.isRequired,
553-
previewIsRefreshing: PropTypes.bool.isRequired,
554-
infiniteLoopMessage: PropTypes.string.isRequired,
555-
projectSavedTime: PropTypes.string,
556503
previousPath: PropTypes.string.isRequired,
557-
justOpenedProject: PropTypes.bool.isRequired,
558-
errorType: PropTypes.string,
559-
runtimeErrorWarningVisible: PropTypes.bool.isRequired,
504+
previewIsRefreshing: PropTypes.bool.isRequired,
505+
isPlaying: PropTypes.bool.isRequired,
506+
isAccessibleOutputPlaying: PropTypes.bool.isRequired,
507+
projectOptionsVisible: PropTypes.bool.isRequired,
508+
preferencesIsVisible: PropTypes.bool.isRequired,
509+
modalIsVisible: PropTypes.bool.isRequired,
560510
uploadFileModalVisible: PropTypes.bool.isRequired,
511+
newFolderModalVisible: PropTypes.bool.isRequired,
512+
justOpenedProject: PropTypes.bool.isRequired,
513+
sidebarIsExpanded: PropTypes.bool.isRequired,
514+
consoleIsExpanded: PropTypes.bool.isRequired,
515+
unsavedChanges: PropTypes.bool.isRequired,
561516
}).isRequired,
562517
stopSketch: PropTypes.func.isRequired,
563518
project: PropTypes.shape({
@@ -572,11 +527,9 @@ IDEView.propTypes = {
572527
editorAccessibility: PropTypes.shape({
573528
lintMessages: PropTypes.array.isRequired, // eslint-disable-line
574529
}).isRequired,
575-
updateLintMessage: PropTypes.func.isRequired,
576-
clearLintMessage: PropTypes.func.isRequired,
577530
preferences: PropTypes.shape({
578-
fontSize: PropTypes.number.isRequired,
579531
autosave: PropTypes.bool.isRequired,
532+
fontSize: PropTypes.number.isRequired,
580533
linewrap: PropTypes.bool.isRequired,
581534
lineNumbers: PropTypes.bool.isRequired,
582535
lintWarning: PropTypes.bool.isRequired,
@@ -585,6 +538,7 @@ IDEView.propTypes = {
585538
soundOutput: PropTypes.bool.isRequired,
586539
theme: PropTypes.string.isRequired,
587540
autorefresh: PropTypes.bool.isRequired,
541+
588542
}).isRequired,
589543
closePreferences: PropTypes.func.isRequired,
590544
setFontSize: PropTypes.func.isRequired,
@@ -601,7 +555,6 @@ IDEView.propTypes = {
601555
name: PropTypes.string.isRequired,
602556
content: PropTypes.string.isRequired,
603557
})).isRequired,
604-
updateFileContent: PropTypes.func.isRequired,
605558
selectedFile: PropTypes.shape({
606559
id: PropTypes.string.isRequired,
607560
content: PropTypes.string.isRequired,
@@ -629,9 +582,6 @@ IDEView.propTypes = {
629582
closeNewFileModal: PropTypes.func.isRequired,
630583
createFolder: PropTypes.func.isRequired,
631584
closeShareModal: PropTypes.func.isRequired,
632-
showEditorOptions: PropTypes.func.isRequired,
633-
closeEditorOptions: PropTypes.func.isRequired,
634-
showKeyboardShortcutModal: PropTypes.func.isRequired,
635585
closeKeyboardShortcutModal: PropTypes.func.isRequired,
636586
toast: PropTypes.shape({
637587
isVisible: PropTypes.bool.isRequired,
@@ -641,22 +591,14 @@ IDEView.propTypes = {
641591
setRouteLeaveHook: PropTypes.func,
642592
}).isRequired,
643593
route: PropTypes.oneOfType([PropTypes.object, PropTypes.element]).isRequired,
644-
setUnsavedChanges: PropTypes.func.isRequired,
645594
setTheme: PropTypes.func.isRequired,
646595
endSketchRefresh: PropTypes.func.isRequired,
647-
startRefreshSketch: PropTypes.func.isRequired,
648596
setBlobUrl: PropTypes.func.isRequired,
649597
setPreviousPath: PropTypes.func.isRequired,
650-
console: PropTypes.arrayOf(PropTypes.shape({
651-
method: PropTypes.string.isRequired,
652-
args: PropTypes.arrayOf(PropTypes.string),
653-
})).isRequired,
654598
clearConsole: PropTypes.func.isRequired,
655599
showErrorModal: PropTypes.func.isRequired,
656600
hideErrorModal: PropTypes.func.isRequired,
657601
clearPersistedState: PropTypes.func.isRequired,
658-
showRuntimeErrorWarning: PropTypes.func.isRequired,
659-
hideRuntimeErrorWarning: PropTypes.func.isRequired,
660602
startSketch: PropTypes.func.isRequired,
661603
openUploadFileModal: PropTypes.func.isRequired,
662604
closeUploadFileModal: PropTypes.func.isRequired,

0 commit comments

Comments
 (0)