Skip to content

Commit 589bdd5

Browse files
committed
💄 update styling for dropdown with <IconButton /> component
1 parent 32efc40 commit 589bdd5

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

client/components/Dropdown.jsx

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,7 @@ const DropdownWrapper = styled.ul`
3636
background-color: ${prop('Button.hover.background')};
3737
color: ${prop('Button.hover.foreground')};
3838
39-
& button, & a {
40-
color: ${prop('Button.hover.foreground')};
41-
}
39+
* { color: ${prop('Button.hover.foreground')}; }
4240
}
4341
4442
li {
@@ -48,17 +46,21 @@ const DropdownWrapper = styled.ul`
4846
align-items: center;
4947
5048
& button,
49+
& button span,
5150
& a {
5251
color: ${prop('primaryTextColor')};
5352
width: 100%;
5453
text-align: left;
54+
justify-content: left;
5555
padding: ${remSize(8)} ${remSize(16)};
5656
}
57+
58+
& button span { padding: 0px }
5759
}
5860
`;
5961

6062
// TODO: Add Icon to the left of the items in the menu
61-
const MaybeIcon = (Element, label) => Element && <Element aria-label={label} />;
63+
// const MaybeIcon = (Element, label) => Element && <Element aria-label={label} />;
6264

6365
const Dropdown = ({ items, align }) => (
6466
<DropdownWrapper align={align} >
@@ -67,7 +69,7 @@ const Dropdown = ({ items, align }) => (
6769
title, icon, href, action
6870
}) => (
6971
<li key={`nav-${title && title.toLowerCase()}`}>
70-
{MaybeIcon(icon, `Navigate to ${title}`)}
72+
{/* {MaybeIcon(icon, `Navigate to ${title}`)} */}
7173
{href
7274
? <IconButton to={href}>{title}</IconButton>
7375
: <IconButton onClick={() => action()}>{title}</IconButton>}

0 commit comments

Comments
 (0)