Skip to content

Commit 5c80702

Browse files
committed
🚧 add MobileSketchView screen to /mobile/preview
2 parents 0877d39 + 81cf415 commit 5c80702

File tree

4 files changed

+58
-5
lines changed

4 files changed

+58
-5
lines changed

client/modules/IDE/pages/IDEViewMobile.jsx

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,19 @@ const Content = styled.div`
3939
margin-top: ${remSize(16)};
4040
`;
4141

42+
const Icon = styled.a`
43+
> svg {
44+
fill: ${textColor};
45+
color: ${textColor};
46+
margin-left: ${remSize(16)};
47+
}
48+
`;
49+
50+
const IconLinkWrapper = styled(Link)`
51+
width: 3rem;
52+
margin-right: 1.25rem;
53+
margin-left: none;
54+
`;
4255

4356
const isUserOwner = ({ project, user }) => (project.owner && project.owner.id === user.id);
4457

@@ -54,9 +67,9 @@ const IDEViewMobile = (props) => {
5467
return (
5568
<Screen>
5669
<Header>
57-
<Link to="/" style={{ width: '3rem', marginRight: '1.25rem' }}>
58-
<CloseIcon viewBox="20 21 60 60" aria-hidden="true" aria-label="close header" />
59-
</Link>
70+
<IconLinkWrapper to="/" aria-label="Return to original editor">
71+
<CloseIcon viewBox="20 21 60 60" />
72+
</IconLinkWrapper>
6073
<div>
6174
<h2>{project.name}</h2>
6275
<h3>{selectedFile.name}</h3>
Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
import React, { useState } from 'react';
2+
3+
import Header from '../../components/mobile/Header';
4+
import Screen from '../../components/mobile/MobileScreen';
5+
6+
const MobileSketchView = (props) => {
7+
const [overlay, setOverlay] = useState(null);
8+
return (
9+
<Screen>
10+
<Header>
11+
{/* <IconLinkWrapper to="/mobile" aria-label="Return to original editor">
12+
<CloseIcon viewBox="20 21 60 60" />
13+
</IconLinkWrapper> */}
14+
<div>
15+
<h2>Hello</h2>
16+
{/* <h3>{selectedFile.name}</h3> */}
17+
</div>
18+
19+
{/* <div style={{ marginLeft: '2rem' }}>
20+
<IconButton onClick={() => setOverlay('preferences')}>
21+
<PreferencesIcon focusable="false" aria-hidden="true" />
22+
</IconButton>
23+
<IconButton onClick={() => setOverlay('runSketch')}>
24+
<PlayIcon viewBox="-1 -1 7 7" focusable="false" aria-hidden="true" />
25+
</IconButton>
26+
</div> */}
27+
</Header>
28+
</Screen>);
29+
};
30+
export default MobileSketchView;

client/routes.jsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,9 @@
1-
import { Route, IndexRoute } from 'react-router';
1+
import { Route, IndexRoute, Router, Switch, useRouteMatch } from 'react-router';
22
import React from 'react';
33
import App from './modules/App/App';
44
import IDEView from './modules/IDE/pages/IDEView';
55
import IDEViewMobile from './modules/IDE/pages/IDEViewMobile';
6+
import MobileSketchView from './modules/Mobile/MobileSketchView';
67
import FullView from './modules/IDE/pages/FullView';
78
import LoginView from './modules/User/pages/LoginView';
89
import SignupView from './modules/User/pages/SignupView';
@@ -50,8 +51,9 @@ const routes = store => (
5051
<Route path="/:username/collections/create" component={DashboardView} />
5152
<Route path="/:username/collections/:collection_id" component={CollectionView} />
5253
<Route path="/about" component={IDEView} />
53-
<Route path="/mobile" component={IDEViewMobile} />
5454

55+
<Route path="/mobile" component={IDEViewMobile} />
56+
<Route path="/mobile/preview" component={MobileSketchView} />
5557
</Route>
5658
);
5759

server/routes/server.routes.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,14 @@ if (process.env.MOBILE_ENABLED) {
118118
router.get('/mobile', (req, res) => {
119119
res.send(renderIndex());
120120
});
121+
122+
router.get('/mobile/preview', (req, res) => {
123+
res.send(renderIndex());
124+
});
125+
126+
router.get('/mobile/*', (req, res) => {
127+
res.send(renderIndex());
128+
});
121129
}
122130

123131
router.get('/:username/collections/create', (req, res) => {

0 commit comments

Comments
 (0)