Merge branch 'develop' into Portuguese-Translation

Author: felipesanchezz

client/components/Nav.jsx

@@ -877,8 +877,6 @@ Nav.propTypes = {
   cmController: PropTypes.shape({
     tidyCode: PropTypes.func,
     showFind: PropTypes.func,
-    findNext: PropTypes.func,
-    findPrev: PropTypes.func,
     showReplace: PropTypes.func,
     getContent: PropTypes.func
   }),

client/modules/IDE/components/Editor.jsx

@@ -85,8 +85,6 @@ class Editor extends React.Component {
       }
     }, 2000);
     this.showFind = this.showFind.bind(this);
-    this.findNext = this.findNext.bind(this);
-    this.findPrev = this.findPrev.bind(this);
     this.showReplace = this.showReplace.bind(this);
     this.getContent = this.getContent.bind(this);
   }
@@ -149,8 +147,8 @@ class Editor extends React.Component {
       [`${metaKey}-Enter`]: () => null,
       [`Shift-${metaKey}-Enter`]: () => null,
       [`${metaKey}-F`]: 'findPersistent',
-      [`${metaKey}-G`]: 'findNext',
-      [`Shift-${metaKey}-G`]: 'findPrev',
+      [`${metaKey}-G`]: 'findPersistentNext',
+      [`Shift-${metaKey}-G`]: 'findPersistentPrev',
       [replaceCommand]: 'replace'
     });
 
@@ -196,8 +194,6 @@ class Editor extends React.Component {
     this.props.provideController({
       tidyCode: this.tidyCode,
       showFind: this.showFind,
-      findNext: this.findNext,
-      findPrev: this.findPrev,
       showReplace: this.showReplace,
       getContent: this.getContent
     });
@@ -317,16 +313,6 @@ class Editor extends React.Component {
     return updatedFile;
   }
 
-  findPrev() {
-    this._cm.focus();
-    this._cm.execCommand('findPrev');
-  }
-
-  findNext() {
-    this._cm.focus();
-    this._cm.execCommand('findNext');
-  }
-
   showFind() {
     this._cm.execCommand('findPersistent');
   }

client/modules/IDE/pages/IDEView.jsx

@@ -101,13 +101,6 @@ class IDEView extends React.Component {
     if (nextProps.location !== this.props.location) {
       this.props.setPreviousPath(this.props.location.pathname);
     }
-
-    if (this.props.ide.consoleIsExpanded !== nextProps.ide.consoleIsExpanded) {
-      this.setState({
-        consoleSize: nextProps.ide.consoleIsExpanded ? 150 : 29
-      });
-    }
-
     if (this.props.ide.sidebarIsExpanded !== nextProps.ide.sidebarIsExpanded) {
       this.setState({
         sidebarSize: nextProps.ide.sidebarIsExpanded ? 160 : 20
@@ -337,7 +330,9 @@ class IDEView extends React.Component {
               <SplitPane
                 split="horizontal"
                 primary="second"
-                size={this.state.consoleSize}
+                size={
+                  this.props.ide.consoleIsExpanded ? this.state.consoleSize : 29
+                }
                 minSize={29}
                 onChange={(size) => this.setState({ consoleSize: size })}
                 allowResize={this.props.ide.consoleIsExpanded}

client/test-utils.js

@@ -1,12 +1,13 @@
 /**
  * This file re-exports @testing-library but ensures that
- * any calls to render have translations available.
+ * any calls to render have translations and theme available.
  *
  * This means tested components will be able to call
  * `t()` and have the translations of the default
- * language
+ * language also components will be able to call
+ * `prop()` and have the theming of the default theme.
  *
- * See: https://react.i18next.com/misc/testing#testing-without-stubbing
+ * For i18n see: https://react.i18next.com/misc/testing#testing-without-stubbing
  */
 
 // eslint-disable-next-line import/no-extraneous-dependencies
@@ -15,15 +16,20 @@ import React from 'react';
 import PropTypes from 'prop-types';
 
 import { I18nextProvider } from 'react-i18next';
+import { ThemeProvider } from 'styled-components';
+
 import i18n from './i18n-test';
+import theme, { Theme } from './theme';
 
 // re-export everything
 // eslint-disable-next-line import/no-extraneous-dependencies
 export * from '@testing-library/react';
 
 const Providers = ({ children }) => (
   // eslint-disable-next-line react/jsx-filename-extension
-  <I18nextProvider i18n={i18n}>{children}</I18nextProvider>
+  <ThemeProvider theme={{ ...theme[Theme.light] }}>
+    <I18nextProvider i18n={i18n}>{children}</I18nextProvider>
+  </ThemeProvider>
 );
 
 Providers.propTypes = {