Skip to content

Commit 7f8ab3c

Browse files
authored
Merge pull request #1265 from thegitone23/local-develop
Added safegaurd against invalid project id and undefined file path
2 parents f1dd9f4 + 919a351 commit 7f8ab3c

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

server/controllers/file.controller.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ export function deleteFile(req, res) {
111111

112112
export function getFileContent(req, res) {
113113
Project.findById(req.params.project_id, (err, project) => {
114-
if (err) {
114+
if (err || project === null) {
115115
res.status(404).send({ success: false, message: 'Project with that id does not exist.' });
116116
return;
117117
}

server/utils/filePath.js

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,8 @@
11
export function resolvePathToFile(filePath, files) {
2+
if (filePath === undefined) {
3+
return false;
4+
}
5+
26
const filePathArray = filePath.split('/');
37
let resolvedFile;
48
let currentFile = files.find(file => file.name === 'root');

0 commit comments

Comments
 (0)