Merge pull request #1744 from processing/chore/lint-warnings

catarak · web-flow · commit 96b01383fa90 · 2021-01-27T15:21:01.000-05:00
[#1698] Remove lint warnings
diff --git a/client/components/Dropdown.jsx b/client/components/Dropdown.jsx
@@ -1,10 +1,8 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import { Link } from 'react-router';
 import styled from 'styled-components';
-import { remSize, prop, common } from '../theme';
+import { remSize, prop } from '../theme';
 import IconButton from './mobile/IconButton';
-import Button from '../common/Button';
 
 const DropdownWrapper = styled.ul`
   background-color: ${prop('Modal.background')};
diff --git a/client/components/mobile/Explorer.jsx b/client/components/mobile/Explorer.jsx
@@ -1,6 +1,5 @@
 import React from 'react';
 import { useTranslation } from 'react-i18next';
-import styled from 'styled-components';
 import PropTypes from 'prop-types';
 import Sidebar from './Sidebar';
 import ConnectedFileNode from '../../modules/IDE/components/FileNode';
diff --git a/client/components/mobile/FloatingNav.jsx b/client/components/mobile/FloatingNav.jsx
@@ -2,7 +2,6 @@ import React from 'react';
 import PropTypes from 'prop-types';
 import styled from 'styled-components';
 import { remSize, prop } from '../../theme';
-import Button from '../../common/Button';
 import IconButton from './IconButton';
 
 const FloatingContainer = styled.div`
diff --git a/client/components/mobile/Footer.jsx b/client/components/mobile/Footer.jsx
@@ -1,6 +1,5 @@
-import React from 'react';
 import styled from 'styled-components';
-import { prop, grays } from '../../theme';
+import { prop } from '../../theme';
 
 const background = prop('MobilePanel.default.background');
 const textColor = prop('primaryTextColor');
diff --git a/client/components/mobile/IDEWrapper.jsx b/client/components/mobile/IDEWrapper.jsx
@@ -1,4 +1,3 @@
-import React from 'react';
 import styled from 'styled-components';
 import { remSize } from '../../theme';
 
diff --git a/client/components/mobile/Sidebar.jsx b/client/components/mobile/Sidebar.jsx
@@ -1,8 +1,7 @@
 import React from 'react';
 import PropTypes from 'prop-types';
-import { Link } from 'react-router';
 import styled from 'styled-components';
-import { remSize, prop, common } from '../../theme';
+import { remSize, prop } from '../../theme';
 import Header from './Header';
 import IconButton from './IconButton';
 import { ExitIcon } from '../../common/icons';
diff --git a/client/components/mobile/Tab.jsx b/client/components/mobile/Tab.jsx
@@ -1,4 +1,3 @@
-import React from 'react';
 import styled from 'styled-components';
 import { Link } from 'react-router';
 import { prop, remSize } from '../../theme';
diff --git a/client/components/mobile/TabSwitcher.jsx b/client/components/mobile/TabSwitcher.jsx
@@ -1,7 +1,6 @@
-import React from 'react';
 import styled from 'styled-components';
 
-import { prop, remSize } from '../../theme';
+import { prop } from '../../theme';
 
 export default styled.div`
   display: flex;
diff --git a/client/i18n.js b/client/i18n.js
@@ -1,6 +1,5 @@
 import i18n from 'i18next';
 import { initReactI18next } from 'react-i18next';
-import LanguageDetector from 'i18next-browser-languagedetector';
 import Backend from 'i18next-http-backend';
 import { enUS, es, ja } from 'date-fns/locale';
 
diff --git a/client/index.jsx b/client/index.jsx
@@ -8,7 +8,7 @@ import configureStore from './store';
 import routes from './routes';
 import ThemeProvider from './modules/App/components/ThemeProvider';
 import Loader from './modules/App/components/loader';
-import i18n from './i18n';
+import './i18n';
 
 require('./styles/main.scss');
 
diff --git a/client/modules/IDE/components/Editor.jsx b/client/modules/IDE/components/Editor.jsx
@@ -93,7 +93,8 @@ class Editor extends React.Component {
   componentDidMount() {
     this.beep = new Audio(beepUrl);
     this.widgets = [];
-    this._cm = CodeMirror(this.codemirrorContainer, { // eslint-disable-line
+    this._cm = CodeMirror(this.codemirrorContainer, {
+      // eslint-disable-line
       theme: `p5-${this.props.theme}`,
       lineNumbers: this.props.lineNumbers,
       styleActiveLine: true,
@@ -141,7 +142,7 @@ class Editor extends React.Component {
       [`${metaKey}-F`]: 'findPersistent',
       [`${metaKey}-G`]: 'findNext',
       [`Shift-${metaKey}-G`]: 'findPrev',
-      replaceCommand: 'replace'
+      [replaceCommand]: 'replace'
     });
 
     this.initializeDocuments(this.props.files);
@@ -349,7 +350,10 @@ class Editor extends React.Component {
     this._docs = {};
     files.forEach((file) => {
       if (file.name !== 'root') {
-        this._docs[file.id] = CodeMirror.Doc(file.content, this.getFileMode(file.name)); // eslint-disable-line
+        this._docs[file.id] = CodeMirror.Doc(
+          file.content,
+          this.getFileMode(file.name)
+        ); // eslint-disable-line
       }
     });
   }
diff --git a/client/modules/IDE/components/PreviewFrame.jsx b/client/modules/IDE/components/PreviewFrame.jsx
@@ -1,14 +1,12 @@
 import PropTypes from 'prop-types';
 import React from 'react';
 import ReactDOM from 'react-dom';
-// import escapeStringRegexp from 'escape-string-regexp';
 import { isEqual } from 'lodash';
 import srcDoc from 'srcdoc-polyfill';
 import loopProtect from 'loop-protect';
 import { JSHINT } from 'jshint';
 import decomment from 'decomment';
 import classNames from 'classnames';
-import { bindActionCreators } from 'redux';
 import { connect } from 'react-redux';
 import { Decode } from 'console-feed';
 import { getBlobUrl } from '../actions/files';
diff --git a/client/modules/IDE/pages/MobileIDEView.jsx b/client/modules/IDE/pages/MobileIDEView.jsx
@@ -227,7 +227,7 @@ const autosave = (autosaveInterval, setAutosaveInterval) => (
 
   const doAutosave = () => autosaveProject(true);
 
-  if (props.isUserOwner && project.id) {
+  if (isUserOwner && project.id) {
     if (preferences.autosave && ide.unsavedChanges && !ide.justOpenedProject) {
       if (file.name === oldFile.name && file.content !== oldFile.content) {
         if (autosaveInterval) {
diff --git a/client/modules/Mobile/MobileDashboardView.jsx b/client/modules/Mobile/MobileDashboardView.jsx
@@ -19,12 +19,10 @@ import {
   SketchSearchbar,
   CollectionSearchbar
 } from '../IDE/components/Searchbar';
-import Button from '../../common/Button';
 import useAsModal from '../../components/useAsModal';
 import Dropdown from '../../components/Dropdown';
 import FooterTabSwitcher from '../../components/mobile/TabSwitcher';
 import FooterTab from '../../components/mobile/Tab';
-import Loader from '../App/components/loader';
 
 const EXAMPLE_USERNAME = 'p5';
 
@@ -148,10 +146,6 @@ const Subheader = styled.div`
   }
 `;
 
-const SubheaderButton = styled(Button)`
-  border-radius: 0px !important;
-`;
-
 const Panels = {
   sketches: SketchList,
   collections: CollectionList,
@@ -181,9 +175,6 @@ const NavItem = styled.li`
   position: relative;
 `;
 
-const isOwner = (user, params) =>
-  user && params && user.username === params.username;
-
 const renderPanel = (name, props) =>
   ((Component) => Component && <Component {...props} mobile />)(Panels[name]);
 
diff --git a/client/modules/Mobile/MobilePreferences.jsx b/client/modules/Mobile/MobilePreferences.jsx
@@ -1,10 +1,9 @@
 import React from 'react';
 import { bindActionCreators } from 'redux';
-import { connect, useSelector, useDispatch } from 'react-redux';
+import { useSelector, useDispatch } from 'react-redux';
 import { withRouter } from 'react-router';
 import { useTranslation } from 'react-i18next';
 
-import PropTypes from 'prop-types';
 import styled from 'styled-components';
 
 import * as PreferencesActions from '../IDE/actions/preferences';
@@ -17,7 +16,6 @@ import PreferencePicker from '../../components/mobile/PreferencePicker';
 import { ExitIcon } from '../../common/icons';
 import { remSize, prop } from '../../theme';
 import {
-  optionsOnOff,
   optionsPickOne,
   preferenceOnOff
 } from '../IDE/components/Preferences/PreferenceCreators';
diff --git a/client/modules/Mobile/MobileSketchView.jsx b/client/modules/Mobile/MobileSketchView.jsx
@@ -1,7 +1,6 @@
 import React from 'react';
 import { bindActionCreators } from 'redux';
 import { useSelector, useDispatch } from 'react-redux';
-import styled from 'styled-components';
 import Header from '../../components/mobile/Header';
 import IconButton from '../../components/mobile/IconButton';
 import PreviewFrame from '../IDE/components/PreviewFrame';
@@ -16,7 +15,6 @@ import * as FilesActions from '../IDE/actions/files';
 import { getHTMLFile } from '../IDE/reducers/files';
 
 import { ExitIcon } from '../../common/icons';
-import { remSize } from '../../theme';
 import Footer from '../../components/mobile/Footer';
 import Content from './MobileViewContent';
 
diff --git a/client/modules/Mobile/MobileViewContent.jsx b/client/modules/Mobile/MobileViewContent.jsx
@@ -1,4 +1,3 @@
-import React from 'react';
 import styled from 'styled-components';
 import { remSize } from '../../theme';
 
diff --git a/client/modules/User/actions.js b/client/modules/User/actions.js
@@ -282,10 +282,7 @@ export function updateSettings(formValues) {
           dispatch(setToastText('Toast.SettingsSaved'));
           resolve();
         })
-        .catch((error) => {
-          const { response } = error;
-          resolve({ error });
-        })
+        .catch((error) => resolve({ error }))
     );
 }
 
diff --git a/client/modules/User/components/ResponsiveForm.jsx b/client/modules/User/components/ResponsiveForm.jsx
@@ -1,6 +1,4 @@
-import React from 'react';
 import styled from 'styled-components';
-import PropTypes from 'prop-types';
 import { remSize } from '../../../theme';
 
 const ResponsiveForm = styled.div`
diff --git a/client/utils/custom-hooks.js b/client/utils/custom-hooks.js
@@ -1,4 +1,4 @@
-import React, { useEffect, useRef, useState } from 'react';
+import { useEffect, useRef, useState } from 'react';
 
 export const noop = () => {};
 
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -174,7 +174,6 @@
     "friendly-words": "^1.1.10",
     "htmlhint": "^0.10.1",
     "i18next": "^19.4.5",
-    "i18next-browser-languagedetector": "^4.2.0",
     "i18next-http-backend": "^1.0.21",
     "is-url": "^1.2.4",
     "jest-express": "^1.11.0",
diff --git a/server/migrations/emailConsolidation.js b/server/migrations/emailConsolidation.js
@@ -31,7 +31,7 @@ mongoose.connection.on('error', () => {
  * https://mongodb.github.io/node-mongodb-native
  */
 
-const agg = [
+const agg = [ // eslint-disable-line
   {
     $project: {
       email: {
diff --git a/server/routes/server.routes.js b/server/routes/server.routes.js
@@ -10,7 +10,7 @@ import { collectionForUserExists } from '../controllers/collection.controller';
 
 const router = new Router();
 
-const fallback404 = (res) => (exists) =>
+const fallback404 = (res) => (exists) => // eslint-disable-line
   exists ? res.send(renderIndex()) : get404Sketch((html) => res.send(html));
 
 // this is intended to be a temporary file
diff --git a/server/scripts/update-syntax-highlighting.js b/server/scripts/update-syntax-highlighting.js
@@ -29,7 +29,8 @@ request('https://p5js.org/reference/data.json', (err, res) => {
 
     let generatedCode = '/* eslint-disable */ \n';
     generatedCode +=
-      '/* generated: do not edit! helper file for syntax highlighting. generated by update-syntax-highlighting script */ \n';
+      '/* generated: do not edit! helper file for syntax highlighting.' +
+      ' generated by update-syntax-highlighting script */ \n';
     generatedCode +=
       'var p5Function = {type: "variable", style: "p5-function"};\n';
     generatedCode +=

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-import React from 'react';`
`2`	`1`	`import styled from 'styled-components';`
`3`	`2`	`import { remSize } from '../../theme';`
`4`	`3`