Skip to content

Commit ca88c4e

Browse files
committed
🚧 put an invisible <Dropdown /> on MobileIDEView
1 parent 24e6b36 commit ca88c4e

File tree

2 files changed

+21
-3
lines changed

2 files changed

+21
-3
lines changed

client/components/Dropdown.jsx

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ import { Link } from 'react-router';
3939
// </li>
4040
// </ul>
4141

42+
// 'nav__item--open'
43+
4244
const Dropdown = ({ items }) => (
4345
<ul className="nav__dropdown">
4446
{items && items.map(item => (

client/modules/IDE/pages/MobileIDEView.jsx

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import Footer from '../../../components/mobile/Footer';
2828
import IDEWrapper from '../../../components/mobile/IDEWrapper';
2929
import Console from '../components/Console';
3030
import { remSize } from '../../../theme';
31+
import Dropdown from '../../../components/Dropdown';
3132

3233
const isUserOwner = ({ project, user }) => (project.owner && project.owner.id === user.id);
3334

@@ -36,6 +37,16 @@ const BottomBarContent = styled.h2`
3637
padding-left: ${remSize(32)};
3738
`;
3839

40+
41+
// TODO: Move to new file?
42+
// const overlays = {};
43+
// const OverlayManager = name => overlays[name] || null;
44+
45+
const headerNavOptions = [
46+
{ icon: PreferencesIcon, title: 'Preferences', route: '/mobile/preferences' }
47+
];
48+
49+
3950
const MobileIDEView = (props) => {
4051
const {
4152
preferences, ide, editorAccessibility, project, updateLintMessage, clearLintMessage,
@@ -48,6 +59,8 @@ const MobileIDEView = (props) => {
4859
const [tmController, setTmController] = useState(null); // eslint-disable-line
4960
const [overlay, setOverlay] = useState(null); // eslint-disable-line
5061

62+
// const overlayActive = name => (overlay === name);
63+
5164
return (
5265
<Screen fullscreen>
5366
<Header
@@ -58,10 +71,10 @@ const MobileIDEView = (props) => {
5871
}
5972
>
6073
<IconButton
61-
to="/mobile/preferences"
62-
onClick={() => setOverlay('preferences')}
74+
// to="/mobile/preferences"
75+
onClick={() => setOverlay('dropdown')}
6376
icon={MoreIcon}
64-
aria-label="Open preferences menu"
77+
aria-label="Options"
6578
/>
6679
<IconButton to="/mobile/preview" onClick={() => { startSketch(); }} icon={PlayIcon} aria-label="Run sketch" />
6780
</Header>
@@ -106,6 +119,9 @@ const MobileIDEView = (props) => {
106119
<Console />
107120
<BottomBarContent>Bottom Bar</BottomBarContent>
108121
</Footer>
122+
123+
{/* Overlays */}
124+
<Dropdown hidden={overlay !== 'dropdown'} items={headerNavOptions} />
109125
</Screen>
110126
);
111127
};

0 commit comments

Comments
 (0)