Skip to content

Commit f3e8b81

Browse files
gabrielsrokacatarak
authored andcommitted
Update IDEView.jsx
`<Overlay...` has a default `title` of `'Modal'` https://github.com/processing/p5.js-web-editor/blob/master/client/modules/App/components/Overlay.jsx#L102 many modals are missing a title, so i added some. i made them basically the same as the `ariaLabel` (but capitalized, changed `-` to ` `, etc)
1 parent 5b191c7 commit f3e8b81

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

client/modules/IDE/pages/IDEView.jsx

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,7 @@ class IDEView extends React.Component {
190190
<Toolbar />
191191
{this.props.ide.preferencesIsVisible &&
192192
<Overlay
193+
title="Settings"
193194
ariaLabel="settings"
194195
closeOverlay={this.props.closePreferences}
195196
>
@@ -363,6 +364,7 @@ class IDEView extends React.Component {
363364
}
364365
{ this.props.location.pathname === '/about' &&
365366
<Overlay
367+
title="About"
366368
previousPath={this.props.ide.previousPath}
367369
ariaLabel="about"
368370
>
@@ -371,6 +373,7 @@ class IDEView extends React.Component {
371373
}
372374
{this.props.location.pathname === '/feedback' &&
373375
<Overlay
376+
title="Submit Feedback"
374377
previousPath={this.props.ide.previousPath}
375378
ariaLabel="submit-feedback"
376379
>
@@ -394,6 +397,7 @@ class IDEView extends React.Component {
394397
}
395398
{this.props.ide.shareModalVisible &&
396399
<Overlay
400+
title="Share"
397401
ariaLabel="share"
398402
closeOverlay={this.props.closeShareModal}
399403
>
@@ -406,6 +410,7 @@ class IDEView extends React.Component {
406410
}
407411
{this.props.ide.keyboardShortcutVisible &&
408412
<Overlay
413+
title="Keyboard Shortcuts"
409414
ariaLabel="keyboard shortcuts"
410415
closeOverlay={this.props.closeKeyboardShortcutModal}
411416
>
@@ -414,6 +419,7 @@ class IDEView extends React.Component {
414419
}
415420
{this.props.ide.errorType &&
416421
<Overlay
422+
title="Error"
417423
ariaLabel="error"
418424
closeOverlay={this.props.hideErrorModal}
419425
>

0 commit comments

Comments
 (0)