Placing donate button text update in useEffect hook
#3668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also increased the timeout to 500 ms, for precaution, and placed the donation logo image URL in a constant, avoiding repetition and keeping the code DRY. |
…ve the `t()` function, since it is probably stable)
…n-use-effect-hook
raclim
approved these changes
Oct 2, 2025
cassiano
deleted the
placing-donate-button-text-update-logic-in-use-effect-hook
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3667
Changes:
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123