Fix and Migrate Version URL Parser #3801
Open
+141
−63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3761
Fixes #3762
Changes
Testing
Testing Strategy Note
The version parsing tests use regex patterns (e.g.,
/^1\.\d+\.\d+$/) rather than hardcoded expected versions (e.g.,'1.11.11'). This approach:p5VersionStringsAlternative approach: Tests could assert exact versions (e.g.,
expect(result.version).toBe('1.11.11')), which would catch sorting bugs but require updates wheneverp5Versionschanges.Sorting bugs are very unlikely to occur unless version numbers change drastically. Current tests simply attempt to prevent future silent errors.
I'm happy to switch to hardcoded assertions or explore other testing strategies if you have suggestions!
I have verified that this pull request:
npm run lint)npm run test)npm run typecheck)developbranch.Fixes #123