Skip to content

Commit 4426d2a

Browse files
committed
Fix: Non-English reference pages will not be translated when the lang file is delayed in loading.
Fixes: #1366 Changes: Added "didReferenceRendered" flag. Translation is now done correctly regardless of whether the "reference-rendered event" or the "after language file is loaded" event occurs first.
1 parent 325ed98 commit 4426d2a

File tree

1 file changed

+12
-4
lines changed

1 file changed

+12
-4
lines changed

src/templates/pages/reference/index.hbs

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,21 @@ slug: reference/
4242
var routes = window.location.pathname.split('/');
4343
var lang = routes[1];
4444
if (langs.indexOf(lang) != -1) {
45+
46+
var didReferenceRendered = false
47+
window.addEventListener('reference-rendered', function() {
48+
console.log("rendered");
49+
didReferenceRendered = true
50+
if (translations) {
51+
updateLanguage();
52+
}
53+
}, false);
54+
4555
$.getJSON('/assets/reference/'+lang+'.json', function(data) {
4656
translations = data;
47-
48-
window.addEventListener('reference-rendered', function() {
49-
console.log("rendered");
57+
if (didReferenceRendered) {
5058
updateLanguage();
51-
}, false);
59+
}
5260
});
5361
}
5462
});

0 commit comments

Comments
 (0)