Skip to content

Commit 96cc270

Browse files
authored
Merge pull request #1317 from aceslowman/3dBasicsTutorial
Resolves issue #1316: corrected asset filepath in WebGL Learn page tutorials
2 parents 6a0ae31 + d5331a4 commit 96cc270

File tree

4 files changed

+16
-16
lines changed

4 files changed

+16
-16
lines changed

src/templates/pages/learn/getting-started-in-webgl-appearance.hbs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -63,21 +63,21 @@ slug: learn/
6363
<p>{{#i18n "getting-started-in-webgl-appearance-p1x1"}}{{/i18n}} <a class="code" href="{{root}}/reference/#/p5/perspective">perspective()</a> {{#i18n "getting-started-in-webgl-appearance-p1x2"}}{{/i18n}} <a
6464
class="code" href="{{root}}/reference/#/p5/ortho">ortho()</a>.</p>
6565

66-
<img style="padding:60px;" src='{{assets}}/learn/basic3D/images/cameraTypeIllustration.png'
66+
<img style="padding:60px;" src='{{assets}}/learn/basic3d/images/cameraTypeIllustration.png'
6767
alt="an illustration showing the difference between perspective and orthographic camera types">
6868

6969
<p>{{#i18n "getting-started-in-webgl-appearance-p2x1"}}{{/i18n}}</p>
7070

7171
{{!-- sketch illustrating 3D camera --}}
72-
<iframe src="{{assets}}/learn/basic3D/cameraExample.html" width="720" height="350">
72+
<iframe src="{{assets}}/learn/basic3d/cameraExample.html" width="720" height="350">
7373
</iframe>
7474

7575
<p>{{#i18n "getting-started-in-webgl-appearance-p3x1"}}{{/i18n}}</p>
7676

7777
<p>{{#i18n "getting-started-in-webgl-appearance-p4x1"}}{{/i18n}}</p>
7878

7979
<div style="display:flex; align-items:center; justify-content: center;">
80-
<img style="width:50%;" src='{{assets}}/learn/basic3D/images/frustum_example.png'
80+
<img style="width:50%;" src='{{assets}}/learn/basic3d/images/frustum_example.png'
8181
alt="an illustration showing the the camera frustum in purple, the near plane represented by a
8282
yellow rectangle near the camera, and far plane as a green rectangle on the opposite end of the frustum volume.">
8383
</div>
@@ -158,7 +158,7 @@ function draw() {
158158
</p>
159159

160160
{{!-- sketch illustrating lighting of geometry --}}
161-
<iframe src="{{assets}}/learn/basic3D/lightingExample.html" width="720" height="350">
161+
<iframe src="{{assets}}/learn/basic3d/lightingExample.html" width="720" height="350">
162162
</iframe>
163163

164164
<p>{{#i18n "getting-started-in-webgl-appearance-p9x1"}}{{/i18n}}</p>
@@ -220,7 +220,7 @@ function draw() {
220220
<p>{{#i18n "getting-started-in-webgl-appearance-p11x1"}}{{/i18n}}</p>
221221

222222
{{!-- sketch illustrating materials --}}
223-
<iframe src="{{assets}}/learn/basic3D/materialsExample.html" width="720" height="350">
223+
<iframe src="{{assets}}/learn/basic3d/materialsExample.html" width="720" height="350">
224224
</iframe>
225225

226226
<p>{{#i18n "getting-started-in-webgl-appearance-p12x1"}}{{/i18n}}</p>
@@ -269,7 +269,7 @@ function draw() {
269269
let myTexture;
270270
271271
function preload() {
272-
myTexture = loadImage("{{assets}}/learn/basic3D/images/simpleTexture.png");
272+
myTexture = loadImage("{{assets}}/learn/basic3d/images/simpleTexture.png");
273273
// map textures between 0 and 1 to match geometry uvs
274274
textureMode(NORMAL);
275275
}

src/templates/pages/learn/getting-started-in-webgl-coords-and-transform.hbs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ slug: learn/
4343
<script src="//toolness.github.io/p5.js-widget/p5-widget.js"></script>
4444

4545
{{!-- large title sketch --}}
46-
<iframe src="{{assets}}/learn/basic3D/titleExample.html" width="720" height="350">
46+
<iframe src="{{assets}}/learn/basic3d/titleExample.html" width="720" height="350">
4747
</iframe>
4848

4949
<h1>{{#i18n "getting-started-in-webgl-coords-and-transform-title"}}{{/i18n}}</h1>
@@ -98,7 +98,7 @@ slug: learn/
9898

9999
<p>{{#i18n "getting-started-in-webgl-coords-and-transform-p6x1"}}{{/i18n}}</p>
100100

101-
<img style="padding:60px;" src='{{assets}}/learn/basic3D/images/2d3d_coordinates.png'
101+
<img style="padding:60px;" src='{{assets}}/learn/basic3d/images/2d3d_coordinates.png'
102102
alt="an illustration showing a 2D coordinate system on the left, showing an origin of (0,0) and a 3D coordinate system on the right, showing an origin of (0,0,0)">
103103

104104
<h2 id="transformations">{{#i18n "getting-started-in-webgl-coords-and-transform-heading3"}}{{/i18n}}</h2>
@@ -113,7 +113,7 @@ slug: learn/
113113
<h3>{{#i18n "getting-started-in-webgl-coords-and-transform-subheading1"}}{{/i18n}}</h3>
114114

115115
{{!-- sketch illustrating translation of geometry --}}
116-
<iframe src="{{assets}}/learn/basic3D/translateExample.html" width="720" height="350">
116+
<iframe src="{{assets}}/learn/basic3d/translateExample.html" width="720" height="350">
117117
</iframe>
118118

119119
<p><a class="code" href="{{root}}/reference/#/p5/translate">translate()</a> {{#i18n
@@ -130,7 +130,7 @@ slug: learn/
130130
<h3>{{#i18n "getting-started-in-webgl-coords-and-transform-subheading2"}}{{/i18n}}</h3>
131131

132132
{{!-- sketch illustrating rotation of geometry --}}
133-
<iframe src="{{assets}}/learn/basic3D/rotateExample.html" width="720" height="350">
133+
<iframe src="{{assets}}/learn/basic3d/rotateExample.html" width="720" height="350">
134134
</iframe>
135135

136136
<p><a class="code" href="{{root}}/reference/#/p5/rotate">rotate()</a> {{#i18n
@@ -176,7 +176,7 @@ slug: learn/
176176
<h3>{{#i18n "getting-started-in-webgl-coords-and-transform-subheading3"}}{{/i18n}}</h3>
177177

178178
{{!-- sketch illustrating scaling of geometry --}}
179-
<iframe src="{{assets}}/learn/basic3D/scaleExample.html" width="720" height="350">
179+
<iframe src="{{assets}}/learn/basic3d/scaleExample.html" width="720" height="350">
180180
</iframe>
181181

182182
<p><a class="code" href="{{root}}/reference/#/p5/scale">scale()</a> {{#i18n
@@ -280,7 +280,7 @@ function draw() {
280280

281281
<p>{{#i18n "getting-started-in-webgl-coords-and-transform-p19x1"}}{{/i18n}}</p>
282282

283-
<img style="padding:60px;" src='{{assets}}/learn/basic3D/images/primitives_example.png'
283+
<img style="padding:60px;" src='{{assets}}/learn/basic3d/images/primitives_example.png'
284284
alt="an illustration showing each of the available primitives in p5.js">
285285

286286
<p>{{#i18n "getting-started-in-webgl-coords-and-transform-p20x1"}}{{/i18n}}<a class="code"

src/templates/pages/learn/getting-started-in-webgl-custom-geometry.hbs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ slug: learn/
7272
let teapotModel;
7373
7474
function preload() {
75-
teapotModel = loadModel('{{assets}}/learn/basic3D/models/teapot.obj', true);
75+
teapotModel = loadModel('{{assets}}/learn/basic3d/models/teapot.obj', true);
7676
}
7777
7878
function setup() {
@@ -143,15 +143,15 @@ function draw(){
143143
{{!-- <div style="display: flex; align-items: center; justify-content: center;">
144144
<p>{{#i18n "getting-started-in-webgl-custom-geometry-p6x2"}}{{/i18n}}</p>
145145
146-
<img style="padding:30px; width:50%;" src='{{assets}}/learn/basic3D/images/normals_face_example.png'
146+
<img style="padding:30px; width:50%;" src='{{assets}}/learn/basic3d/images/normals_face_example.png'
147147
alt="an illustration a collection of three points, constituting a face, and an arrow extending perpendicular to it, the normal" />
148148
</div> --}}
149149

150150

151151
<p>{{#i18n "getting-started-in-webgl-custom-geometry-p6x2"}}{{/i18n}}</p>
152152

153153
<div style="display: flex; align-items: center; justify-content: center;">
154-
<img style="padding:30px; width:60%;" src='{{assets}}/learn/basic3D/images/normals_face_example.png'
154+
<img style="padding:30px; width:60%;" src='{{assets}}/learn/basic3d/images/normals_face_example.png'
155155
alt="an illustration a collection of three points, constituting a face, and an arrow extending perpendicular to it, the normal" />
156156
</div>
157157

src/templates/pages/learn/getting-started-in-webgl-shaders.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -222,7 +222,7 @@ void main() {
222222
gl_FragColor = vec4(uv,1.0,1.0);
223223
}
224224
</code></pre>
225-
<img style="padding:30px;width:30%;" src='{{assets}}/learn/basic3D/images/uv_example.png'
225+
<img style="padding:30px;width:30%;" src='{{assets}}/learn/basic3d/images/uv_example.png'
226226
alt="an illustration showing UV coordinates, the x axis in red, and the y axis in blue.">
227227
</div>
228228

0 commit comments

Comments
 (0)