Skip to content

Commit a290db8

Browse files
committed
Merge branch 'main' into pr/1265
2 parents fe4d75f + f6e59d5 commit a290db8

File tree

12 files changed

+854
-579
lines changed

12 files changed

+854
-579
lines changed

Gruntfile.js

Lines changed: 20 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -342,8 +342,22 @@ module.exports = function(grunt) {
342342
dest: 'p5-reference/'
343343
}
344344
},
345-
htmllint: {
346-
all: {
345+
346+
htmlhint: {
347+
html1: {
348+
options: {
349+
'attr-value-double-quotes': false,
350+
'alt-require': true,
351+
'doctype-first': true,
352+
'title-require': true,
353+
'attr-no-duplication': true,
354+
'input-requires-label': true,
355+
'tags-check': true,
356+
'tagname-lowercase': true,
357+
'tagname-specialchars': true,
358+
'empty-tag-not-self-closed': true,
359+
'id-unique': true
360+
},
347361
src: [
348362
'<%= config.dist %>/**/*.html',
349363
'!<%= config.dist %>/**/CHANGES.html',
@@ -352,17 +366,10 @@ module.exports = function(grunt) {
352366
'!<%= config.dist %>/**/learn/*.html',
353367
'!<%= config.dist %>/**/examples/*.html',
354368
'!<%= config.dist %>/**/reference/assets/index.html'
355-
],
356-
options: {
357-
ignore: [
358-
/^This document appears to be written in English/,
359-
/^Bad value https:/,
360-
/^Consider adding a lang attribute to the html/,
361-
/^Attribute paypalexpress not allowed on element script at this point./
362-
]
363-
}
369+
]
364370
}
365371
},
372+
366373
shell: {
367374
generate_dataJSON: {
368375
command: `git checkout ${grunt.option('target')} && npm ci && npm run grunt yui build`,
@@ -402,7 +409,7 @@ module.exports = function(grunt) {
402409
grunt.loadNpmTasks('grunt-file-append');
403410
grunt.loadNpmTasks('grunt-contrib-compress');
404411
grunt.loadNpmTasks('grunt-contrib-requirejs');
405-
grunt.loadNpmTasks('grunt-html');
412+
grunt.loadNpmTasks('grunt-htmlhint');
406413

407414
// i18n tracking task
408415
grunt.registerTask('i18n', function() {
@@ -495,7 +502,7 @@ module.exports = function(grunt) {
495502
'file_append',
496503
'compress',
497504
'i18n',
498-
'htmllint'
505+
'htmlhint'
499506
]);
500507

501508
// runs with just grunt command

README.md

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ If you discover a bug or have an idea for a new feature you'd like to add, begin
1010

1111
We recognize all types of contributions. This project follows the [all-contributors](https://github.com/kentcdodds/all-contributors) specification. Add yourself to the [p5.js repository readme](https://github.com/processing/p5.js/blob/main/README.md#contributors) by following the [instructions here](https://github.com/processing/p5.js/issues/2309)!
1212

13+
## Add Yourself to Contributors
14+
15+
If you've contributed to this website (or any other part of the p5.js project), add yourself [here](https://github.com/processing/p5.js#contributors). Instructions to do this can be found at the bottom of the section.
16+
1317
## Stewards
1418
Stewards are contributors that are particularly involved, familiar, or responsive to certain areas of the project. Their role is to help provide context and guidance to others working on p5.js website. If you have a question about contributing to a particular area, you can tag the listed steward in an issue or pull request. They may also weigh in on feature requests and guide the overall direction of their area, with the input of the community. You can read more about the organization of the project at [contributor_docs/organization.md](https://github.com/processing/p5.js/blob/main/contributor_docs/organization.md).
1519

@@ -44,9 +48,10 @@ Once added, a steward's username will remain in the [stewards section of the rea
4448
Other Language Steward(s):
4549
* Portuguese: [@raphaelavelar](https://github.com/raphaelavelar)
4650

51+
52+
4753
## Setup
4854

49-
0. Ensure Java is installed. Not installed? Head over to [Java](https://www.oracle.com/java/technologies/downloads/) for installation.
5055
1. Install [node.js](https://nodejs.org/en/download/).
5156
2. Clone this repo by typing ```git clone https://github.com/processing/p5.js-website/``` in terminal.
5257
3. Navigate to the `p5.js-website` directory in the terminal and type `npm install`.
@@ -75,13 +80,8 @@ Once you've setup the site, type `npm run watch` to run the website. This should
7580
* [grunt-assemble-i18n](https://github.com/assemble/grunt-assemble-i18n) renders a set of pages for each language specified in the gruntfile, based on the handlebars templates and yml data. There is not a lot of documentation, but this [example](https://github.com/LaurentGoderre/i18n-demo) demonstrates the functionality well.
7681
* [assemble-contrib-permalinks](https://github.com/assemble/assemble-permalinks) allows us to customize the permalinks (file structure of the rendered static site).
7782

78-
## Add yourself to contributors!
79-
80-
If you've contributed to this website (or any other part of the p5.js project), add yourself [here](https://github.com/processing/p5.js#contributors). Instructions to do this can be found at the bottom of the section.
81-
82-
## Etc
83-
* [Instructions for contributing to website translation/internationalization](https://github.com/processing/p5.js-website/blob/main/contributor_docs/i18n_contribution.md)
84-
* [Introducción a p5.js](https://github.com/processing/p5.js-getting-started-es) - The repository for the book and PDF production of [Introducción a p5.js](http://p5js.org/books/).
83+
## Translation/i18n
84+
* [Instructions](https://github.com/processing/p5.js-website/blob/main/contributor_docs/i18n_contribution.md) for contributing to website translation/internationalization
8585

8686
## Externally hosted language versions
8787
* [https://p5js.jp](https://p5js.jp/) - 日本語 (Japanese), translated and hosted by [Katsuya Endoh](https://enkatsu.org/)

0 commit comments

Comments
 (0)