Skip to content

Commit 440f0f1

Browse files
tsengwoodycoseeian
authored andcommitted
Fix "hide banner" button not contained within any landmark region
1 parent c4ff54c commit 440f0f1

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/components/Banner/index.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ const { link, title } = entry.data;
66
---
77

88
<div class="banner bg-accent-color text-accent-type-color" style={{ display: 'none' }} data-title={title}>
9-
<a class="banner-content" href={link} target="_blank">
9+
<a class="banner-content" href={link} target="_blank" title="Opens in new tab">
1010
<Content />
1111
</a>
1212
<button id="hideBanner" aria-label="Hide banner"><Icon kind="close" /></button>

src/components/Footer/index.astro

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,8 +83,8 @@ const bannerEntry = await getEntry("banner", currentLocale);
8383
</ul>
8484
</div>
8585
</div>
86+
{bannerEntry && !bannerEntry.data.hidden && (<Banner entry={bannerEntry} />)}
8687
</footer>
87-
{bannerEntry && !bannerEntry.data.hidden && (<Banner entry={bannerEntry} />)}
8888

8989
<style></style>
9090

0 commit comments

Comments
 (0)