Skip to content

Commit cfb7f89

Browse files
committed
fix: use hidden attribute for menu visibility and remove dynamic tabIndex
1 parent fd545a3 commit cfb7f89

File tree

1 file changed

+8
-14
lines changed

1 file changed

+8
-14
lines changed

src/components/Nav/MainNavLinks.tsx

Lines changed: 8 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -76,31 +76,25 @@ export const MainNavLinks = ({
7676
<ul id="main-links-list" hidden={!isOpen}>
7777
{links.map((link) => (
7878
<li key={link.label}>
79-
<a href={link.url} tabIndex={isOpen ? undefined : -1}>
80-
{link.label}
81-
</a>
79+
<a href={link.url}>{link.label}</a>
8280
</li>
8381
))}
8482
</ul>
85-
<ul id="main-cta-list" class="flex flex-col gap-[15px]" hidden={!isOpen}>
83+
<ul
84+
id="main-cta-list"
85+
class={`${isOpen ? "flex" : ""} flex-col gap-[15px]`}
86+
hidden={!isOpen}
87+
>
8688
<li>
87-
<a
88-
className={styles.buttonlink}
89-
href="https://editor.p5js.org"
90-
tabIndex={isOpen ? undefined : -1}
91-
>
89+
<a className={styles.buttonlink} href="https://editor.p5js.org">
9290
<div class="mr-xxs">
9391
<Icon kind="code-brackets" />
9492
</div>
9593
{editorButtonLabel}
9694
</a>
9795
</li>
9896
<li>
99-
<a
100-
className={styles.buttonlink}
101-
href="/donate/"
102-
tabIndex={isOpen ? undefined : -1}
103-
>
97+
<a className={styles.buttonlink} href="/donate/">
10498
<div class="mr-xxs">
10599
<Icon kind="heart" />
106100
</div>

0 commit comments

Comments
 (0)