Skip to content

refactor: change div to aside for accessibility in settings component #1003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

refactor: change div to aside for accessibility in settings component #1003

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63855be
refactor: change div to aside for accessibility in settings component
hxrshxz Oct 16, 2025
ebd15eb
Merge branch 'main' into settings-component
hxrshxz Oct 16, 2025
f8003c3
Merge branch 'main' into settings-component
hxrshxz Oct 22, 2025
edd3ddd
Merge branch 'main' into settings-component
hxrshxz Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/components/Settings/index.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ const a11ySettingsProps = [
const { hideSearch } = Astro.props;
---

<div class={`${styles.container} ${jumpToState ? "" : "noJumpTo"}`}>
<aside class={`${styles.container} ${jumpToState ? "" : "noJumpTo"}`} aria-label="Settings">
<div id="settings-placeholder" class={styles.placeholder}></div>
<div id="settings-hitbox" class={styles.hitbox}></div>
<div id="settings-container" class={`${styles.wrapper} settings`}>
Expand All @@ -97,5 +97,5 @@ const { hideSearch } = Astro.props;
)
}
</div>
</div>
</aside>
<script src="./script.js"></script>