From 4c932f462b055b21a237e2e1d64eacc6a71818b6 Mon Sep 17 00:00:00 2001 From: Mayank Date: Sat, 30 Aug 2025 21:38:38 +0530 Subject: [PATCH 1/2] fix(ui): resolved active link underline issue --- src/components/Nav/JumpToLinks.tsx | 17 +++++++++++------ src/components/Nav/styles.module.scss | 24 +++++++++++++++--------- 2 files changed, 26 insertions(+), 15 deletions(-) diff --git a/src/components/Nav/JumpToLinks.tsx b/src/components/Nav/JumpToLinks.tsx index c848d26377..9e6f5ba581 100644 --- a/src/components/Nav/JumpToLinks.tsx +++ b/src/components/Nav/JumpToLinks.tsx @@ -18,27 +18,32 @@ export const JumpToLinks = ({ if (!links || links?.length <= 0) return null; return ( -
+
- +// ✅ Active link underline bug fixed on 30-Aug-2025 {isOpen && ( diff --git a/src/components/Nav/styles.module.scss b/src/components/Nav/styles.module.scss index 3d201ed7d8..a7f31efd46 100644 --- a/src/components/Nav/styles.module.scss +++ b/src/components/Nav/styles.module.scss @@ -223,19 +223,26 @@ -webkit-text-stroke-width: 0.15px; } } - .linklabel { - &:global(.current) { - text-decoration-line: underline; + a { + color: inherit; + text-decoration: none; + &.current { + text-decoration: underline; + text-decoration-thickness: 2px; + text-underline-offset: 2px; + } } +} - &:not(:global(.small)) { + &:not(.small) { // text-h3 font-size: 1.5rem; line-height: 1.167; -webkit-text-stroke-width: 0.15px; } - &:global(.small) { + + &.small { // text-body font-size: 1rem; line-height: 1.25; @@ -243,21 +250,20 @@ } @media (min-width: $breakpoint-tablet) { - &:global(.small) { + &.small { // text-body-caption font-size: 0.875rem; line-height: 1.42; -webkit-text-stroke-width: 0.1px; } - &:not(&:global(.small)) { + + &:not(.small) { // text-body-large font-size: 1.25rem; line-height: 1.2; -webkit-text-stroke-width: 0.15px; } } -} - .linklabel:not(:global(.small)) + .linklabel:global(.small) { margin-top: 4px; } From 770a1b1aec59d9ac6d689968e385c4cc1a66da46 Mon Sep 17 00:00:00 2001 From: Mayank Date: Sat, 30 Aug 2025 21:53:40 +0530 Subject: [PATCH 2/2] fix(ui): resolved active link underline issue --- src/components/Nav/JumpToLinks.tsx | 9 ++++----- src/components/Nav/styles.module.scss | 7 ++----- 2 files changed, 6 insertions(+), 10 deletions(-) diff --git a/src/components/Nav/JumpToLinks.tsx b/src/components/Nav/JumpToLinks.tsx index 9e6f5ba581..91a4ec948b 100644 --- a/src/components/Nav/JumpToLinks.tsx +++ b/src/components/Nav/JumpToLinks.tsx @@ -18,19 +18,18 @@ export const JumpToLinks = ({ if (!links || links?.length <= 0) return null; return ( -
+
-// ✅ Active link underline bug fixed on 30-Aug-2025 {isOpen && (
    {links?.map((link) => ( diff --git a/src/components/Nav/styles.module.scss b/src/components/Nav/styles.module.scss index a7f31efd46..8c3fdcc100 100644 --- a/src/components/Nav/styles.module.scss +++ b/src/components/Nav/styles.module.scss @@ -235,15 +235,14 @@ } } + .linklabel { &:not(.small) { - // text-h3 font-size: 1.5rem; line-height: 1.167; -webkit-text-stroke-width: 0.15px; } &.small { - // text-body font-size: 1rem; line-height: 1.25; -webkit-text-stroke-width: 0.05px; @@ -251,19 +250,17 @@ @media (min-width: $breakpoint-tablet) { &.small { - // text-body-caption font-size: 0.875rem; line-height: 1.42; -webkit-text-stroke-width: 0.1px; } - &:not(.small) { - // text-body-large font-size: 1.25rem; line-height: 1.2; -webkit-text-stroke-width: 0.15px; } } +} .linklabel:not(:global(.small)) + .linklabel:global(.small) { margin-top: 4px; }