Skip to content

Commit 05adbdc

Browse files
authored
Merge branch 'main' into touchstarted-fix
2 parents 33f754e + 9ef898f commit 05adbdc

31 files changed

+660
-112
lines changed

.all-contributorsrc

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5583,6 +5583,33 @@
55835583
"doc",
55845584
"bug"
55855585
]
5586+
},
5587+
{
5588+
"login": "deveshidwivedi",
5589+
"name": "Deveshi Dwivedi",
5590+
"avatar_url": "https://avatars.githubusercontent.com/u/120312681?v=4",
5591+
"profile": "https://github.com/deveshidwivedi",
5592+
"contributions": [
5593+
"code"
5594+
]
5595+
},
5596+
{
5597+
"login": "mohitbalwani",
5598+
"name": "Mohit Balwani",
5599+
"avatar_url": "https://avatars.githubusercontent.com/u/73066030?v=4",
5600+
"profile": "https://github.com/mohitbalwani",
5601+
"contributions": [
5602+
"code"
5603+
]
5604+
},
5605+
{
5606+
"login": "rahulrangers",
5607+
"name": "rahulrangers",
5608+
"avatar_url": "https://avatars.githubusercontent.com/u/127782777?v=4",
5609+
"profile": "https://github.com/rahulrangers",
5610+
"contributions": [
5611+
"code"
5612+
]
55865613
}
55875614
],
55885615
"repoType": "github",
Lines changed: 98 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,98 @@
1+
name: 📃 p5.js 2.0 RFC Proposal
2+
description: This template is for submitting a proposal to the p5.js 2.0 RFC.
3+
title: "[p5.js 2.0 RFC Proposal]: "
4+
labels: [p5.js 2.0]
5+
body:
6+
- type: textarea
7+
attributes:
8+
label: Increasing access
9+
description: How would this proposal help [increase access](https://github.com/processing/p5.js/blob/main/contributor_docs/access.md) to p5.js? (If you're not sure, you can type "Unsure" here and let others from the community offer their thoughts.)
10+
validations:
11+
required: true
12+
- type: markdown
13+
attributes:
14+
value: |
15+
### Acceptance criteria
16+
The [p5.js 2.0 RFC](https://github.com/processing/p5.js/blob/dev-2.0/rfc_p5js_2.md) is a compilation of proposals for the next major version of p5.js.
17+
18+
**✖️ New features**: In order to focus the community's efforts, proposals for new features will typically not be accepted into the RFC. A [New Feature Request](https://github.com/processing/p5.js/issues/new?assignees=&labels=Feature+Request&projects=&template=feature-request.yml) may still be submitted, but it will only be considered after the release of p5.js 2.0.
19+
20+
**✔️Existing features**: This proposal will be accepted if the community determines it would improve an existing feature through a breaking change, a systemic change, or an overdue change.
21+
- type: checkboxes
22+
id: type-of-change
23+
attributes:
24+
label: Which types of changes would be made?
25+
description: Please select at least one.
26+
options:
27+
- label: Breaking change (Add-on libraries or sketches will work differently even if their code stays the same.)
28+
- label: Systemic change (Many features or contributor workflows will be affected.)
29+
- label: Overdue change (Modifications will be made that have been desirable for a long time.)
30+
- label: Unsure (The community can help to determine the type of change.)
31+
- type: checkboxes
32+
id: sub-area
33+
attributes:
34+
label: Most appropriate sub-area of p5.js?
35+
description: Please select at least one.
36+
options:
37+
- label: Accessibility
38+
- label: Color
39+
- label: Core/Environment/Rendering
40+
- label: Data
41+
- label: DOM
42+
- label: Events
43+
- label: Image
44+
- label: IO
45+
- label: Math
46+
- label: Typography
47+
- label: Utilities
48+
- label: WebGL
49+
- label: Build process
50+
- label: Unit testing
51+
- label: Internationalization
52+
- label: Friendly errors
53+
- label: Other (specify if possible)
54+
- type: textarea
55+
attributes:
56+
label: What's the problem?
57+
description: Describe the problem this proposal aims to solve. (Use as much space as you need.)
58+
validations:
59+
required: true
60+
- type: textarea
61+
attributes:
62+
label: What's the solution?
63+
description: Describe how you would solve the problem. (For large proposals, a summary is fine; this proposal can link to sub-issues for details.)
64+
validations:
65+
required: true
66+
- type: textarea
67+
attributes:
68+
label: Pros (updated based on community comments)
69+
description: Indicate the advantages of implementing this proposal. If the community identifies more advantages in the comments, please add them.
70+
value: |
71+
Example list:
72+
* **Consistency:** This proposal increases API consistency by...
73+
* **Readability:** This proposal makes the source code more readable by...
74+
* Other advantages...
75+
validations:
76+
required: true
77+
- type: textarea
78+
attributes:
79+
label: Cons (updated based on community comments)
80+
description: Indicate the disadvantages of implementing this proposal, if you know of any. If the community identifies disadvantages in the comments, please add them.
81+
placeholder: None so far...
82+
validations:
83+
required: true
84+
- type: dropdown
85+
attributes:
86+
label: Proposal status
87+
options:
88+
- Under review
89+
- Accepted
90+
- Not accepted
91+
default: 0
92+
validations:
93+
required: true
94+
- type: markdown
95+
attributes:
96+
value: |
97+
### Implementation process
98+
If this proposal is accepted, it will be included in the p5.js 2.0 RFC. A contributor who has participated in the discussion will then be assigned to lead the implementation, which will happen on the [dev-2.0](https://github.com/processing/p5.js/tree/dev-2.0) branch.

.github/ISSUE_TEMPLATE/existing-feature-enhancement.yml renamed to .github/ISSUE_TEMPLATE/3-existing-feature-enhancement.yml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ labels: [Enhancement]
44
body:
55
- type: textarea
66
attributes:
7-
label: Increasing Access
7+
label: Increasing access
88
description: How would this new feature help [increase access](https://github.com/processing/p5.js/blob/main/contributor_docs/access.md) to p5.js? (If you're not sure, you can type "Unsure" here and let others from the community offer their thoughts.)
99
validations:
1010
required: true
@@ -26,13 +26,18 @@ body:
2626
- label: Typography
2727
- label: Utilities
2828
- label: WebGL
29-
- label: Build Process
30-
- label: Unit Testing
31-
- label: Internalization
32-
- label: Friendly Errors
29+
- label: Build process
30+
- label: Unit testing
31+
- label: Internationalization
32+
- label: Friendly errors
3333
- label: Other (specify if possible)
3434
- type: textarea
3535
attributes:
3636
label: Feature enhancement details
3737
validations:
3838
required: true
39+
- type: markdown
40+
attributes:
41+
value: |
42+
### Implementation process
43+
We are currently prioritizing proposals for [p5.js 2.0](https://github.com/processing/p5.js/blob/dev-2.0/rfc_p5js_2.md). Work on this issue may begin after that version is released, provided there is community support.

.github/ISSUE_TEMPLATE/feature-request.yml renamed to .github/ISSUE_TEMPLATE/4-feature-request.yml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ labels: [Feature Request]
44
body:
55
- type: textarea
66
attributes:
7-
label: Increasing Access
7+
label: Increasing access
88
description: How would this new feature help [increase access](https://github.com/processing/p5.js/blob/main/contributor_docs/access.md) to p5.js? (If you're not sure, you can type "Unsure" here and let others from the community offer their thoughts.)
99
validations:
1010
required: true
@@ -26,13 +26,18 @@ body:
2626
- label: Typography
2727
- label: Utilities
2828
- label: WebGL
29-
- label: Build Process
30-
- label: Unit Testing
31-
- label: Internalization
32-
- label: Friendly Errors
29+
- label: Build process
30+
- label: Unit testing
31+
- label: Internationalization
32+
- label: Friendly errors
3333
- label: Other (specify if possible)
3434
- type: textarea
3535
attributes:
3636
label: Feature request details
3737
validations:
3838
required: true
39+
- type: markdown
40+
attributes:
41+
value: |
42+
### Implementation process
43+
We are currently prioritizing proposals for [p5.js 2.0](https://github.com/processing/p5.js/blob/dev-2.0/rfc_p5js_2.md). Work on this issue may begin after that version is released, provided there is community support.

.github/ISSUE_TEMPLATE/found-a-bug.yml renamed to .github/ISSUE_TEMPLATE/5-found-a-bug.yml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,10 @@ body:
2020
- label: Typography
2121
- label: Utilities
2222
- label: WebGL
23-
- label: Build Process
24-
- label: Unit Testing
25-
- label: Internalization
26-
- label: Friendly Errors
23+
- label: Build process
24+
- label: Unit testing
25+
- label: Internationalization
26+
- label: Friendly errors
2727
- label: Other (specify if possible)
2828
- type: input
2929
attributes:
@@ -39,7 +39,7 @@ body:
3939
required: false
4040
- type: input
4141
attributes:
42-
label: Operating System
42+
label: Operating system
4343
description: "Ex: Windows/MacOSX/Linux/Android/iOS along with version"
4444
validations:
4545
required: false

.github/workflows/release.yml

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ on:
88
push:
99
tags:
1010
- 'v*.*.*' # Push events to matching v*.*.*, i.e. v20.15.10
11+
- 'v*.*.*-*' # Push events to matching v*.*.*-*, i.e. v20.15.10-0
1112

1213
jobs:
1314
release:
@@ -21,11 +22,18 @@ jobs:
2122
- uses: actions/setup-node@v3
2223
with:
2324
node-version: 18
25+
- name: Get semver info
26+
id: semver
27+
uses: akshens/semver-tag@v4
28+
with:
29+
version: ${{ github.ref_name }}
30+
2431
- name: Get version number
2532
id: version-number
2633
run: |
2734
version=$(echo ${{ github.ref_name }} | cut -c 2-)
2835
echo "version=$version" >> $GITHUB_OUTPUT
36+
2937
- name: Get current date
3038
id: date
3139
run: echo "date=$(date +"%B %Oe, %Y")" >> $GITHUB_OUTPUT
@@ -56,27 +64,33 @@ jobs:
5664
uses: softprops/[email protected]
5765
with:
5866
draft: true
67+
prerelease: ${{ steps.semver.outputs.is-prerelease == 'true' }}
5968
files: release/*
6069
generate_release_notes: true
6170
token: ${{ secrets.ACCESS_TOKEN }}
6271
- name: Publish to NPM
72+
if: ${{ steps.semver.outputs.is-prerelease != 'true' }}
6373
uses: JS-DevTools/npm-publish@v1
6474
with:
6575
token: ${{ secrets.NPM_TOKEN }}
6676

6777
# 4. Update website files
6878
- name: Checkout website repo
79+
if: ${{ steps.semver.outputs.is-prerelease != 'true' }}
6980
uses: actions/checkout@v3
7081
with:
7182
repository: processing/p5.js-website
7283
path: website
7384
fetch-depth: 0
7485
token: ${{ secrets.ACCESS_TOKEN }}
7586
- name: Copy reference files to website repo
87+
if: ${{ steps.semver.outputs.is-prerelease != 'true' }}
7688
run: cp docs/reference/data.* website/src/templates/pages/reference/
7789
- name: Copy library files to website repo
90+
if: ${{ steps.semver.outputs.is-prerelease != 'true' }}
7891
run: cp lib/p5.min.js lib/addons/p5.sound.min.js website/src/assets/js/
7992
- name: Modify version number on website
93+
if: ${{ steps.semver.outputs.is-prerelease != 'true' }}
8094
uses: fjogeleit/[email protected]
8195
with:
8296
valueFile: website/src/data/data.yml
@@ -85,23 +99,27 @@ jobs:
8599
commitChange: false
86100
updateFile: true
87101
- name: Update version.json on website repo
102+
if: ${{ steps.semver.outputs.is-prerelease != 'true' }}
88103
uses: restackio/[email protected]
89104
with:
90105
file: website/dist/download/version.json
91106
fields: '{"version": "${{ steps.version-number.outputs.version }}", "date": "${{ steps.date.outputs.date }}"}'
92107
- name: Update en.json on website repo
108+
if: ${{ steps.semver.outputs.is-prerelease != 'true' }}
93109
run: |
94110
cd website
95111
npm ci
96112
npx grunt generate_enJSON
97113
- name: Commit updated website files
114+
if: ${{ steps.semver.outputs.is-prerelease != 'true' }}
98115
run: |
99116
cd website
100117
git config --local user.email "41898282+github-actions[bot]@users.noreply.github.com"
101118
git config --local user.name "github-actions[bot]"
102119
git add .
103120
git commit -m "Update p5.js to ${{ github.ref_name }}"
104121
- name: Push updated website repo
122+
if: ${{ steps.semver.outputs.is-prerelease != 'true' }}
105123
uses: ad-m/[email protected]
106124
with:
107125
github_token: ${{ secrets.ACCESS_TOKEN }}
@@ -111,24 +129,28 @@ jobs:
111129

112130
# 5. Update Bower files
113131
- name: Checkout Bower repo
132+
if: ${{ steps.semver.outputs.is-prerelease != 'true' }}
114133
uses: actions/checkout@v3
115134
with:
116135
repository: processing/p5.js-release
117136
path: bower
118137
fetch-depth: 0
119138
token: ${{ secrets.ACCESS_TOKEN }}
120139
- name: Copy new version files to Bower repo
140+
if: ${{ steps.semver.outputs.is-prerelease != 'true' }}
121141
run: |
122142
cp lib/*.js bower/lib/
123143
cp lib/addons/* bower/lib/addons/
124144
- name: Commit updated Bower files
145+
if: ${{ steps.semver.outputs.is-prerelease != 'true' }}
125146
run: |
126147
cd bower
127148
git config --local user.email "41898282+github-actions[bot]@users.noreply.github.com"
128149
git config --local user.name "github-actions[bot]"
129150
git add .
130151
git commit -m "Update p5.js to ${{ github.ref_name }}"
131152
- name: Push updated Bower repo
153+
if: ${{ steps.semver.outputs.is-prerelease != 'true' }}
132154
uses: ad-m/[email protected]
133155
with:
134156
github_token: ${{ secrets.ACCESS_TOKEN }}

README.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ Check out [p5js.org](https://p5js.org) for lots more! Here are some quick-links
3737
* [p5.js overview](https://github.com/processing/p5.js/wiki/p5.js-overview): An overview of the main features and functionality of p5.js
3838
* [Reference](https://p5js.org/reference): The functionality supported by p5.js
3939
* [Learn](https://p5js.org/learn): Tutorials and short, prototypical examples exploring the basics of p5.js
40-
* [Forum](https://discourse.processing.org/c/p5js): Ask and answers questions about how to make things with p5.js here
40+
* [Forum](https://discourse.processing.org/c/p5js): Ask and answer questions about how to make things with p5.js here
4141
* [Libraries](https://p5js.org/libraries): Extend p5 functionality to interact with HTML, manipulate sound, and more!
4242
* [The Coding Train p5.js Tutorials](https://thecodingtrain.com/beginners/p5js/): A huge trove of tutorials created by Dan Shiffman and friends
4343

@@ -947,6 +947,11 @@ We recognize all types of contributions. This project follows the [all-contribut
947947
<td align="center" valign="top" width="16.66%"><a href="https://github.com/PracDuckling"><img src="https://avatars.githubusercontent.com/u/68885144?v=4?s=120" width="120px;" alt="PracDuckling"/><br /><sub><b>PracDuckling</b></sub></a><br /><a href="https://github.com/processing/p5.js/issues?q=author%3APracDuckling" title="Bug reports">🐛</a> <a href="https://github.com/processing/p5.js/commits?author=PracDuckling" title="Documentation">📖</a></td>
948948
<td align="center" valign="top" width="16.66%"><a href="https://github.com/PoulavBhowmick03"><img src="https://avatars.githubusercontent.com/u/133862694?v=4?s=120" width="120px;" alt="Poulav Bhowmick"/><br /><sub><b>Poulav Bhowmick</b></sub></a><br /><a href="https://github.com/processing/p5.js/issues?q=author%3APoulavBhowmick03" title="Bug reports">🐛</a> <a href="https://github.com/processing/p5.js/commits?author=PoulavBhowmick03" title="Documentation">📖</a></td>
949949
<td align="center" valign="top" width="16.66%"><a href="https://keshav-malik99.netlify.app/"><img src="https://avatars.githubusercontent.com/u/91189139?v=4?s=120" width="120px;" alt="Keshav Malik"/><br /><sub><b>Keshav Malik</b></sub></a><br /><a href="https://github.com/processing/p5.js/commits?author=keshav-0907" title="Code">💻</a> <a href="https://github.com/processing/p5.js/commits?author=keshav-0907" title="Documentation">📖</a> <a href="https://github.com/processing/p5.js/issues?q=author%3Akeshav-0907" title="Bug reports">🐛</a></td>
950+
<td align="center" valign="top" width="16.66%"><a href="https://github.com/deveshidwivedi"><img src="https://avatars.githubusercontent.com/u/120312681?v=4?s=120" width="120px;" alt="Deveshi Dwivedi"/><br /><sub><b>Deveshi Dwivedi</b></sub></a><br /><a href="https://github.com/processing/p5.js/commits?author=deveshidwivedi" title="Code">💻</a></td>
951+
</tr>
952+
<tr>
953+
<td align="center" valign="top" width="16.66%"><a href="https://github.com/mohitbalwani"><img src="https://avatars.githubusercontent.com/u/73066030?v=4?s=120" width="120px;" alt="Mohit Balwani"/><br /><sub><b>Mohit Balwani</b></sub></a><br /><a href="https://github.com/processing/p5.js/commits?author=mohitbalwani" title="Code">💻</a></td>
954+
<td align="center" valign="top" width="16.66%"><a href="https://github.com/rahulrangers"><img src="https://avatars.githubusercontent.com/u/127782777?v=4?s=120" width="120px;" alt="rahulrangers"/><br /><sub><b>rahulrangers</b></sub></a><br /><a href="https://github.com/processing/p5.js/commits?author=rahulrangers" title="Code">💻</a></td>
950955
</tr>
951956
</tbody>
952957
</table>

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
"node --require @babel/register ./utils/sample-linter.js"
2525
]
2626
},
27-
"version": "1.9.0",
27+
"version": "1.9.1-1",
2828
"devDependencies": {
2929
"@babel/core": "^7.7.7",
3030
"@babel/preset-env": "^7.10.2",

0 commit comments

Comments
 (0)