Merge pull request #7027 from IronBlood/fix/7019-index-of-attributes

limzykenneth · web-flow · commit 61d8eb8a29a3 · 2024-05-14T22:31:22.000+01:00
fix: add the missing index of `attributes`
diff --git a/src/io/p5.XML.js b/src/io/p5.XML.js
@@ -234,7 +234,7 @@ p5.XML = class  {
     const newDOM = xmlDoc.createElement(name);
     newDOM.innerHTML = content;
     for (let i = 0; i < attributes.length; i++) {
-      newDOM.setAttribute(attributes[i].nodeName, attributes.nodeValue);
+      newDOM.setAttribute(attributes[i].nodeName, attributes[i].nodeValue);
     }
     this.DOM = newDOM;
   }

Original file line number	Diff line number	Diff line change
`@@ -234,7 +234,7 @@ p5.XML = class {`
`234`	`234`	`const newDOM = xmlDoc.createElement(name);`
`235`	`235`	`newDOM.innerHTML = content;`
`236`	`236`	`for (let i = 0; i < attributes.length; i++) {`
`237`		`- newDOM.setAttribute(attributes[i].nodeName, attributes.nodeValue);`
	`237`	`+ newDOM.setAttribute(attributes[i].nodeName, attributes[i].nodeValue);`
`238`	`238`	`}`
`239`	`239`	`this.DOM = newDOM;`
`240`	`240`	`}`