Skip to content

Commit 78cb39d

Browse files
committed
fixing-tests
1 parent 50d6530 commit 78cb39d

File tree

2 files changed

+25
-9
lines changed

2 files changed

+25
-9
lines changed

lib/empty-example/sketch.js

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,17 @@
1+
let g;
2+
13
function setup() {
2-
// put setup code here
3-
}
4-
5-
function draw() {
6-
// put drawing code here
7-
}
4+
createCanvas(400, 400);
5+
6+
g = createGraphics(200, 200);
7+
}
8+
9+
function draw() {
10+
g.background(0);
11+
g.stroke(255, 0, 0);
12+
g.strokeWeight(5);
13+
g.noFill();
14+
g.bezier(0, 0, 100, 0, 0, 100, 200, 200);
15+
//Comment out this line and for some reason the bezier gets drawn (to the canvas instead of the graphics object)
16+
image(g, 0, 0, 400, 400);
17+
}

src/dom/p5.Element.js

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,16 @@ class Element {
6464
}
6565

6666
// delete the reference in this._pInst._elements
67-
const index = this._pInst._elements.indexOf(this);
68-
if (index !== -1) {
69-
this._pInst._elements.splice(index, 1);
67+
let sketch = this._pInst;
68+
if (sketch && !sketch._elements && sketch._pInst) {
69+
sketch = sketch._pInst; // climb one level up
7070
}
71+
72+
if (sketch && sketch._elements) { // only if the array exists
73+
const i = sketch._elements.indexOf(this);
74+
if (i !== -1) sketch._elements.splice(i, 1);
75+
}
76+
7177

7278
// deregister events
7379
for (let ev in this._events) {

0 commit comments

Comments
 (0)