Skip to content

Commit a20ceef

Browse files
remove redundant code
1 parent 11a500a commit a20ceef

File tree

1 file changed

+16
-23
lines changed

1 file changed

+16
-23
lines changed

src/math/p5.Vector.js

Lines changed: 16 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -449,7 +449,7 @@ p5.Vector = class {
449449
);
450450
}
451451
} else if (Array.isArray(x)) {
452-
if (x.every(element => Number.isFinite(element))) {
452+
if (x.every(Number.isFinite)) {
453453
if (x.length === 2) {
454454
return this.calculateRemainder2D(x[0], x[1]);
455455
}
@@ -465,25 +465,19 @@ p5.Vector = class {
465465
return this;
466466
}
467467
} else if (args.length === 2) {
468-
const vectorComponents = args;
469-
if (vectorComponents.every(element => Number.isFinite(element))) {
470-
if (vectorComponents.length === 2) {
471-
return this.calculateRemainder2D(
472-
x,
473-
y
474-
);
475-
}
468+
if (args.every(Number.isFinite)) {
469+
return this.calculateRemainder2D(
470+
x,
471+
y
472+
);
476473
}
477474
} else if (args.length === 3) {
478-
const vectorComponents = args;
479-
if (vectorComponents.every(element => Number.isFinite(element))) {
480-
if (vectorComponents.length === 3) {
481-
return this.calculateRemainder3D(
482-
x,
483-
y,
484-
z
485-
);
486-
}
475+
if (args.every(Number.isFinite)) {
476+
return this.calculateRemainder3D(
477+
x,
478+
y,
479+
z
480+
);
487481
}
488482
}
489483
}
@@ -998,7 +992,7 @@ p5.Vector = class {
998992
}
999993
if (Array.isArray(x)) {
1000994
if (
1001-
x.every(element => Number.isFinite(element)) &&
995+
x.every(Number.isFinite) &&
1002996
x.every(element => typeof element === 'number')
1003997
) {
1004998
if (x.some(element => element === 0)) {
@@ -1028,12 +1022,11 @@ p5.Vector = class {
10281022
return this;
10291023
}
10301024

1031-
const vectorComponents = args;
10321025
if (
1033-
vectorComponents.every(element => Number.isFinite(element)) &&
1034-
vectorComponents.every(element => typeof element === 'number')
1026+
args.every(Number.isFinite) &&
1027+
args.every(element => typeof element === 'number')
10351028
) {
1036-
if (vectorComponents.some(element => element === 0)) {
1029+
if (args.some(element => element === 0)) {
10371030
console.warn('p5.Vector.prototype.div:', 'divide by 0');
10381031
return this;
10391032
}

0 commit comments

Comments
 (0)