Fix Broken examples for textOutput() and gridOutput() #8125
Conversation
…iling known limitations and alternatives for accessible canvas descriptions.
|
🎉 Thanks for opening this pull request! For guidance on contributing, check out our contributor guidelines and other resources for contributors! Thank You! |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the JSDoc documentation for the textOutput() and gridOutput() accessibility methods by adding comprehensive information about their known limitations and recommending alternative approaches.
- Added detailed documentation of limitations for both methods (English-only descriptions, WEBGL incompatibility, shape detection issues)
- Recommended
describe()anddescribeElement()as more accurate alternatives - Improved developer awareness of when these methods may not work as expected
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
hxrshxz
changed the title
|
@perminder-17 Please have a look |
There was a problem hiding this comment.
Hi @hxrshxz, thanks for your work on fixing the examples! Please see the comments, and also please change the body of your issue to "addresses #issue-number" because the scope of the linked issue is larger than this PR, so it should remain open
hxrshxz
changed the title
|
I have moved the documentation part into a separate PR #8143 |
3 participants
Addresses #6992
Changes:
Before
Screencast.from.2025-10-06.21-48-30.mp4
Screencast.from.2025-10-06.22-32-44.mp4
After
Screencast.from.2025-10-06.21-50-31.mp4
Screencast.from.2025-10-06.22-34-55.mp4
PR Checklist
npm run lintpasses