Skip to content

Commit 1043bc9

Browse files
committed
fix error when donwloading tools
1 parent f37a574 commit 1043bc9

File tree

3 files changed

+48
-21
lines changed

3 files changed

+48
-21
lines changed

mode/src/processing/mode/android/AndroidSDK.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -275,7 +275,7 @@ public File getZipAlignTool() {
275275

276276

277277
// Write to the process input, so the licenses will be accepted. In
278-
// principle, We only need 7 'y', one for the 'yes' to the first
278+
// principle, we only need 7 'y', one for the 'yes' to the first
279279
// 'review licenses?' question, the rest for the 6 licenses, but adding
280280
// 10 just in case, having more does not cause any trouble.
281281
private static final String response = "y\ny\ny\ny\ny\ny\ny\ny\ny\ny\n";

mode/src/processing/mode/android/AndroidTool.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,9 @@ public String initLoader(String className) throws Exception {
8989

9090
// Add .jar and .zip files from the "tool" and the SDK/tools/lib
9191
// folder into the classpath
92-
File libDir = new File(sdk.getToolsFolder(), "lib");
92+
// File d = sdk.getToolsFolder();
93+
File libDir = new File(folder, "lib");
94+
// File libDir = new File(d, "lib");
9395
File[] toolArchives = Util.listJarFiles(toolDir);
9496
File[] libArchives = Util.listJarFiles(libDir);
9597

mode/src/processing/mode/android/SDKDownloader.java

Lines changed: 44 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ private void getMainDownloadUrls(SDKUrlHolder urlHolder,
291291
remotePackages = (NodeList) expr.evaluate(doc, XPathConstants.NODESET);
292292
found = false;
293293
if (remotePackages != null) {
294-
for(int buildTool=0; buildTool < remotePackages.getLength(); buildTool++) {
294+
for (int buildTool = 0; buildTool < remotePackages.getLength(); buildTool++) {
295295
NodeList childNodes = remotePackages.item(buildTool).getChildNodes();
296296

297297
NodeList channel = ((Element) childNodes).getElementsByTagName("channelRef");
@@ -337,25 +337,50 @@ private void getMainDownloadUrls(SDKUrlHolder urlHolder,
337337
remotePackages = (NodeList) expr.evaluate(doc, XPathConstants.NODESET);
338338
found = false;
339339
if (remotePackages != null) {
340-
NodeList childNodes = remotePackages.item(1).getChildNodes(); // Second item is the latest tools for now
341-
NodeList archives = ((Element) childNodes).getElementsByTagName("archive");
342-
343-
for (int i = 0; i < archives.getLength(); ++i) {
344-
NodeList archive = archives.item(i).getChildNodes();
345-
NodeList complete = ((Element) archive).getElementsByTagName("complete");
340+
for (int tool = 0; tool < remotePackages.getLength(); tool++) {
341+
NodeList childNodes = remotePackages.item(tool).getChildNodes();
342+
343+
NodeList archives = ((Element) childNodes).getElementsByTagName("archive");
344+
for (int i = 0; i < archives.getLength(); ++i) {
345+
NodeList archive = archives.item(i).getChildNodes();
346+
NodeList complete = ((Element) archive).getElementsByTagName("complete");
346347

347-
NodeList os = ((Element) archive).getElementsByTagName("host-os");
348-
NodeList url = ((Element) complete.item(0)).getElementsByTagName("url");
349-
NodeList size = ((Element) complete.item(0)).getElementsByTagName("size");
350-
351-
if (os.item(0).getTextContent().equals(requiredHostOs)) {
352-
urlHolder.toolsFilename = url.item(0).getTextContent();
353-
urlHolder.toolsUrl = REPOSITORY_URL + urlHolder.toolsFilename;
354-
urlHolder.totalSize += Integer.parseInt(size.item(0).getTextContent());
355-
found = true;
356-
break;
348+
NodeList os = ((Element) archive).getElementsByTagName("host-os");
349+
NodeList url = ((Element) complete.item(0)).getElementsByTagName("url");
350+
NodeList size = ((Element) complete.item(0)).getElementsByTagName("size");
351+
352+
if (os.item(0).getTextContent().equals(requiredHostOs)) {
353+
urlHolder.toolsFilename = url.item(0).getTextContent();
354+
urlHolder.toolsUrl = REPOSITORY_URL + urlHolder.toolsFilename;
355+
urlHolder.totalSize += Integer.parseInt(size.item(0).getTextContent());
356+
found = true;
357+
break;
358+
}
357359
}
360+
if (found) break;
358361
}
362+
363+
// NodeList childNodes = remotePackages.item(1).getChildNodes(); // Second item is the latest tools for now
364+
// NodeList archives = ((Element) childNodes).getElementsByTagName("archive");
365+
//
366+
// for (int i = 0; i < archives.getLength(); ++i) {
367+
// NodeList archive = archives.item(i).getChildNodes();
368+
// NodeList complete = ((Element) archive).getElementsByTagName("complete");
369+
//
370+
// NodeList os = ((Element) archive).getElementsByTagName("host-os");
371+
// NodeList url = ((Element) complete.item(0)).getElementsByTagName("url");
372+
// NodeList size = ((Element) complete.item(0)).getElementsByTagName("size");
373+
//
374+
// if (os.item(0).getTextContent().equals(requiredHostOs)) {
375+
// urlHolder.toolsFilename = url.item(0).getTextContent();
376+
// urlHolder.toolsUrl = REPOSITORY_URL + urlHolder.toolsFilename;
377+
// urlHolder.totalSize += Integer.parseInt(size.item(0).getTextContent());
378+
// found = true;
379+
// break;
380+
// }
381+
// }
382+
383+
359384
}
360385
if (!found) {
361386
throw new IOException(AndroidMode.getTextString("sdk_downloader.error_cannot_find_tools"));
@@ -367,7 +392,7 @@ private void getMainDownloadUrls(SDKUrlHolder urlHolder,
367392
remotePackages = (NodeList) expr.evaluate(doc, XPathConstants.NODESET);
368393
found = false;
369394
if (remotePackages != null) {
370-
for(int i = 0; i < remotePackages.getLength(); ++i) {
395+
for (int i = 0; i < remotePackages.getLength(); ++i) {
371396
NodeList childNodes = remotePackages.item(i).getChildNodes();
372397

373398
NodeList channel = ((Element) childNodes).getElementsByTagName("channelRef");
@@ -456,7 +481,7 @@ private void getHaxmDownloadUrl(SDKUrlHolder urlHolder,
456481
expr = xpath.compile("//remotePackage[@path=\"extras;intel;Hardware_Accelerated_Execution_Manager\"]");
457482
remotePackages = (NodeList) expr.evaluate(doc, XPathConstants.NODESET);
458483
if (remotePackages != null) {
459-
for (int i=0; i < remotePackages.getLength(); ++i) {
484+
for (int i = 0; i < remotePackages.getLength(); ++i) {
460485
NodeList childNodes = remotePackages.item(i).getChildNodes();
461486
NodeList archives = ((Element) childNodes).getElementsByTagName("archive");
462487

0 commit comments

Comments
 (0)