Skip to content

Commit 477f134

Browse files
committed
Replaced sun.misc.BASE64Encoder with java.util.Base64
1 parent fdfad99 commit 477f134

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

mode/src/processing/mode/android/JarSigner.java

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,12 @@
3535
import java.util.jar.Manifest;
3636
import java.util.zip.ZipEntry;
3737
import java.util.zip.ZipInputStream;
38-
import sun.misc.BASE64Encoder;
39-
import sun.security.pkcs.ContentInfo;
40-
import sun.security.pkcs.PKCS7;
38+
import java.util.Base64;
4139
import sun.security.pkcs.SignerInfo;
4240
import sun.security.x509.AlgorithmId;
4341
import sun.security.x509.X500Name;
42+
import sun.security.pkcs.PKCS7;
43+
import sun.security.pkcs.ContentInfo;
4444

4545
/**
4646
* Created by ibziy_000 on 17.08.2014.
@@ -90,7 +90,7 @@ public static void signJar(File jarToSign, File outputJar, String alias,
9090

9191
private static void writeZip(InputStream input, JarOutputStream output, Manifest manifest)
9292
throws IOException, NoSuchAlgorithmException {
93-
BASE64Encoder base64Encoder = new BASE64Encoder();
93+
Base64.Encoder base64Encoder = Base64.getEncoder();
9494
MessageDigest messageDigest = MessageDigest.getInstance(DIGEST_ALGORITHM);
9595
buffer = new byte[4096];
9696

@@ -127,7 +127,7 @@ private static void writeZip(InputStream input, JarOutputStream output, Manifest
127127
}
128128

129129
private static void writeEntry(JarOutputStream output, InputStream input, JarEntry entry,
130-
MessageDigest digest, Manifest manifest, BASE64Encoder encoder) throws IOException {
130+
MessageDigest digest, Manifest manifest, Base64.Encoder encoder) throws IOException {
131131
output.putNextEntry(entry);
132132

133133
// Write input stream to the jar output.
@@ -146,7 +146,7 @@ private static void writeEntry(JarOutputStream output, InputStream input, JarEnt
146146
attr = new Attributes();
147147
manifest.getEntries().put(entry.getName(), attr);
148148
}
149-
attr.putValue(DIGEST_ATTR, encoder.encode(digest.digest()));
149+
attr.putValue(DIGEST_ATTR, encoder.encodeToString(digest.digest()));
150150
}
151151
}
152152

@@ -182,7 +182,7 @@ private static void writeSignatureFile(SignatureOutputStream out, Manifest manif
182182
main.putValue("Signature-Version", "1.0");
183183
main.putValue("Created-By", "1.0 (Android)");
184184

185-
BASE64Encoder base64 = new BASE64Encoder();
185+
Base64.Encoder base64 = Base64.getEncoder();
186186
MessageDigest md = MessageDigest.getInstance(DIGEST_ALGORITHM);
187187
PrintStream print = new PrintStream(
188188
new DigestOutputStream(new ByteArrayOutputStream(), md),
@@ -191,7 +191,7 @@ private static void writeSignatureFile(SignatureOutputStream out, Manifest manif
191191
// Digest of the entire manifest
192192
manifest.write(print);
193193
print.flush();
194-
main.putValue(DIGEST_MANIFEST_ATTR, base64.encode(md.digest()));
194+
main.putValue(DIGEST_MANIFEST_ATTR, base64.encodeToString(md.digest()));
195195

196196
Map<String, Attributes> entries = manifest.getEntries();
197197
for (Map.Entry<String, Attributes> entry : entries.entrySet()) {
@@ -204,7 +204,7 @@ private static void writeSignatureFile(SignatureOutputStream out, Manifest manif
204204
print.flush();
205205

206206
Attributes sfAttr = new Attributes();
207-
sfAttr.putValue(DIGEST_ATTR, base64.encode(md.digest()));
207+
sfAttr.putValue(DIGEST_ATTR, base64.encodeToString(md.digest()));
208208
sf.getEntries().put(entry.getKey(), sfAttr);
209209
}
210210

@@ -230,6 +230,7 @@ private static void writeSignature(JarOutputStream outputJar,
230230
private static void writeSignatureBlock(JarOutputStream outputJar,
231231
Signature signature, X509Certificate publicKey, PrivateKey privateKey)
232232
throws IOException, GeneralSecurityException {
233+
233234
SignerInfo signerInfo = new SignerInfo(
234235
new X500Name(publicKey.getIssuerX500Principal().getName()),
235236
publicKey.getSerialNumber(),

0 commit comments

Comments
 (0)