Skip to content

Commit 5cc0c57

Browse files
committed
Include all required deps by updated and lang support
1 parent df48e40 commit 5cc0c57

File tree

5 files changed

+60
-26
lines changed

5 files changed

+60
-26
lines changed

mode/languages/mode.properties

Lines changed: 24 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -209,8 +209,6 @@ android_devices.error.no_permissions_body = Make sure that the device has USB de
209209
"";
210210

211211
private static final String DEVICE_PERMISSIONS_MESSAGE =
212-
213-
214212

215213
# ---------------------------------------
216214
# Keystore manager
@@ -283,3 +281,27 @@ download_property.change_event_total = total
283281
download_property.change_event_downloaded = downloaded
284282
download_prompt.cancel = Cancel download
285283

284+
# ---------------------------------------
285+
# SDK Updater tool
286+
287+
sdk_updater.name_column = Package name
288+
sdk_updater.version_column = Installed version
289+
sdk_updater.available_column = Available update
290+
291+
sdk_updater.query_message = Querying packages...
292+
293+
sdk_updater.no_updates_message = No updates available
294+
sdk_updater.one_updates_message = 1 update found!
295+
sdk_updater.many_updates_message = "%d" updates found!
296+
297+
sdk_updater.warning_failed_finding_package = Failed to find package "%s"
298+
sdk_updater.warning_failed_computing_dependency_list = Unable to compute a complete list of dependencies.
299+
300+
sdk_updater.refresh_package_message = Refreshing packages...
301+
sdk_updater.download_package_message = Downloading available updates...
302+
sdk_updater.download_canceled_message = Download canceled
303+
304+
sdk_updater.update_button_label = Update
305+
sdk_updater.cancel_button_label = Cancel
306+
sdk_updater.close_button_label = Close
307+

mode/src/processing/mode/android/SDKDownloader.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,7 @@ private void getMainDownloadUrls(SDKUrlHolder urlHolder,
296296

297297
NodeList channel = ((Element) childNodes).getElementsByTagName("channelRef");
298298
if(!channel.item(0).getAttributes().item(0).getNodeValue().equals("channel-0"))
299-
continue; //Stable channel only, skip others
299+
continue; // Stable channel only, skip others
300300

301301
NodeList revision = ((Element) childNodes).getElementsByTagName("revision");
302302
String major = (((Element) revision.item(0)).getElementsByTagName("major")).item(0).getTextContent();
@@ -333,7 +333,6 @@ private void getMainDownloadUrls(SDKUrlHolder urlHolder,
333333

334334
// -----------------------------------------------------------------------
335335
// Command-line tools
336-
// expr = xpath.compile("//remotePackage[@path=\"cmdline-tools;\"]");
337336
expr = xpath.compile("//remotePackage[starts-with(@path, \"cmdline-tools;\")]");
338337
remotePackages = (NodeList) expr.evaluate(doc, XPathConstants.NODESET);
339338
found = false;

mode/tools/SDKUpdater/build.gradle

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,17 +8,28 @@ configurations {
88
dependencies {
99
compile group: "org.processing", name: "pde", version: "${processingVersion}"
1010

11+
compile group: "org.processing", name: "java-mode", version: "${processingVersion}"
12+
compile fileTree(include: ["AndroidMode.jar"], dir: '../../mode')
13+
1114
compileAndCopy group: "com.android.tools", name: "sdklib", version: "${toolsLibVersion}"
1215
compileAndCopy group: "com.android.tools", name: "repository", version: "${toolsLibVersion}"
1316
}
1417

1518
// This task copies the gradle tooling jar into the mode folder
1619
task copyToLib(type: Copy) {
1720
from configurations.compileAndCopy.files {
18-
include '**/sdklib*'
19-
include '**/repository*'
21+
include '**/annotations-*'
22+
include '**/common-*'
23+
include '**/dvlib-*'
24+
include '**/gson-*'
25+
include '**/guava-*'
26+
include '**/httpcore-*'
27+
include '**/kotlin-stdlib-*'
28+
include '**/layoutlib-api-*'
29+
include '**/repository-*'
30+
include '**/sdklib-*'
2031
}
21-
into "lib"
32+
into "tool"
2233
}
2334
build.dependsOn(copyToLib)
2435

@@ -32,7 +43,6 @@ sourceSets {
3243

3344
clean.doFirst {
3445
delete "tool"
35-
delete "lib"
3646
}
3747

3848
build.doLast {

mode/tools/SDKUpdater/src/processing/mode/android/tools/SDKUpdater.java

Lines changed: 20 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import processing.app.Preferences;
3636
import processing.app.tools.Tool;
3737
import processing.app.ui.Toolkit;
38+
import processing.mode.android.AndroidMode;
3839

3940
import javax.swing.*;
4041
import javax.swing.border.EmptyBorder;
@@ -69,7 +70,9 @@ public class SDKUpdater extends JFrame implements PropertyChangeListener, Tool {
6970
final static private int BUTTON_HEIGHT = Toolkit.zoom(25);
7071

7172
private final Vector<String> columns = new Vector<>(Arrays.asList(
72-
"Package name", "Installed version", "Available update"));
73+
AndroidMode.getTextString("sdk_updater.name_column"),
74+
AndroidMode.getTextString("sdk_updater.version_column"),
75+
AndroidMode.getTextString("sdk_updater.available_column")));
7376
private static final String PROPERTY_CHANGE_QUERY = "query";
7477

7578
private File sdkFolder;
@@ -102,13 +105,13 @@ public void run() {
102105
queryTask = new QueryTask();
103106
queryTask.addPropertyChangeListener(this);
104107
queryTask.execute();
105-
status.setText("Querying packages...");
108+
status.setText(AndroidMode.getTextString("sdk_updater.query_message"));
106109
}
107-
110+
108111

109112
@Override
110-
public String getMenuTitle() {
111-
return "menu.android.sdk_updater";
113+
public String getMenuTitle() {
114+
return AndroidMode.getTextString("menu.android.sdk_updater");
112115
}
113116

114117

@@ -119,13 +122,13 @@ public void propertyChange(PropertyChangeEvent evt) {
119122
progressBar.setIndeterminate(false);
120123
if (numUpdates == 0) {
121124
actionButton.setEnabled(false);
122-
status.setText("No updates available");
125+
status.setText(AndroidMode.getTextString("sdk_updater.no_updates_message"));
123126
} else {
124127
actionButton.setEnabled(true);
125128
if (numUpdates == 1) {
126-
status.setText("1 update found!");
129+
status.setText(AndroidMode.getTextString("sdk_updater.one_updates_message"));
127130
} else {
128-
status.setText(numUpdates + " updates found!");
131+
status.setText(AndroidMode.getTextString("sdk_updater.many_updates_message", numUpdates));
129132
}
130133
}
131134
break;
@@ -277,7 +280,7 @@ protected Object doInBackground() throws Exception {
277280
for (String path : settings.getPaths(mRepoManager)) {
278281
RemotePackage p = mRepoManager.getPackages().getRemotePackages().get(path);
279282
if (p == null) {
280-
progress.logWarning("Failed to find package " + path);
283+
progress.logWarning(AndroidMode.getTextString("sdk_updater.warning_failed_finding_package", path));
281284
throw new SdkManagerCli.CommandFailedException();
282285
}
283286
remotes.add(p);
@@ -294,7 +297,7 @@ protected Object doInBackground() throws Exception {
294297
}
295298
}
296299
} else {
297-
progress.logWarning("Unable to compute a complete list of dependencies.");
300+
progress.logWarning(AndroidMode.getTextString("sdk_updater.warning_failed_computing_dependency_list"));
298301
throw new SdkManagerCli.CommandFailedException();
299302
}
300303

@@ -308,7 +311,7 @@ protected void done() {
308311
try {
309312
get();
310313
actionButton.setEnabled(false);
311-
status.setText("Refreshing packages...");
314+
status.setText(AndroidMode.getTextString("sdk_updater.refresh_package_message"));
312315
queryTask = new QueryTask();
313316
queryTask.addPropertyChangeListener(SDKUpdater.this);
314317
queryTask.execute();
@@ -457,8 +460,8 @@ public void actionPerformed(ActionEvent e) {
457460
// };
458461
// update.start();
459462

460-
status.setText("Downloading available updates...");
461-
actionButton.setText("Cancel");
463+
status.setText(AndroidMode.getTextString("sdk_updater.download_package_message"));
464+
actionButton.setText(AndroidMode.getTextString("sdk_updater.cancel_button_label"));
462465
}
463466
}
464467
});
@@ -481,7 +484,7 @@ public void actionPerformed(ActionEvent actionEvent) {
481484
}
482485
};
483486

484-
JButton closeButton = new JButton("Close");
487+
JButton closeButton = new JButton(AndroidMode.getTextString("sdk_updater.close_button_label"));
485488
closeButton.setPreferredSize(new Dimension(BUTTON_WIDTH, BUTTON_HEIGHT));
486489
closeButton.addActionListener(disposer);
487490
closeButton.setEnabled(true);
@@ -520,10 +523,10 @@ public void cancelTasks() {
520523
queryTask.cancel(true);
521524
if (downloadTaskRunning) {
522525
downloadTask.cancel(true);
523-
status.setText("Download canceled");
526+
status.setText(AndroidMode.getTextString("sdk_updater.download_canceled_message"));
524527
JOptionPane.showMessageDialog(null,
525-
"Download canceled", "Warning", JOptionPane.WARNING_MESSAGE);
526-
actionButton.setText("Update");
528+
AndroidMode.getTextString("sdk_updater.download_canceled_message"), "Warning", JOptionPane.WARNING_MESSAGE);
529+
actionButton.setText(AndroidMode.getTextString("sdk_updater.update_button_label"));
527530
}
528531
}
529532

settings.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
include ':core', ':mode:libraries:vr', ':mode:libraries:ar', 'mode:tools:SDKUpdater', ':mode'
1+
include ':core', ':mode', ':mode:libraries:vr', ':mode:libraries:ar', 'mode:tools:SDKUpdater'
22

0 commit comments

Comments
 (0)