Skip to content

Commit 5d3e2ea

Browse files
committed
some minor code refactor
1 parent 46aa26b commit 5d3e2ea

File tree

2 files changed

+16
-14
lines changed

2 files changed

+16
-14
lines changed

mode/src/processing/mode/android/AndroidBuild.java

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -770,28 +770,31 @@ private File signPackage(File projectFolder, String keyStorePassword, String fil
770770
File keyStore = AndroidKeyStore.getKeyStore();
771771
if (keyStore == null) return null;
772772

773-
String path=getPathToAPK();
774-
if (fileExt.equals("aab")) {
773+
String path;
774+
boolean isAAB = fileExt.equals("aab");
775+
if (isAAB) {
775776
path = getPathToAAB();
777+
} else {
778+
path = getPathToAPK();
776779
}
777-
File unsignedPackage = new File(projectFolder,
778-
path + sketch.getName().toLowerCase() + "_release_unsigned." + fileExt);
779-
if (!unsignedPackage.exists()) return null;
780-
File signedPackage = new File(projectFolder,
781-
path + sketch.getName().toLowerCase() + "_release_signed." + fileExt);
782780

781+
File unsignedPackage = new File(projectFolder,
782+
path + sketch.getName().toLowerCase() + "_release_unsigned." + fileExt);
783+
if (!unsignedPackage.exists()) return null;
784+
File signedPackage = new File(projectFolder,
785+
path + sketch.getName().toLowerCase() + "_release_signed." + fileExt);
783786

784-
JarSigner.signJar(unsignedPackage, signedPackage,
787+
JarSigner.signJarV1(unsignedPackage, signedPackage,
785788
AndroidKeyStore.ALIAS_STRING, keyStorePassword,
786789
keyStore.getAbsolutePath(), keyStorePassword);
787790

788-
if (fileExt.equals("aab")) {
791+
if (isAAB) {
789792
return signedPackage;
793+
} else {
794+
File alignedPackage = zipalignPackage(signedPackage, projectFolder, fileExt);
795+
return alignedPackage;
790796
}
791-
File alignedPackage = zipalignPackage(signedPackage, projectFolder, fileExt);
792-
return alignedPackage;
793797
}
794-
795798

796799
private File zipalignPackage(File signedPackage, File projectFolder, String fileExt)
797800
throws IOException, InterruptedException {
@@ -801,7 +804,6 @@ private File zipalignPackage(File signedPackage, File projectFolder, String file
801804
AndroidMode.getTextString("android_build.warn.cannot_find_zipalign.body"));
802805
return null;
803806
}
804-
805807

806808
File alignedPackage = new File(projectFolder,
807809
getPathToAPK() + sketch.getName().toLowerCase() + "_release_signed_aligned."+fileExt);

mode/src/processing/mode/android/JarSigner.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public class JarSigner {
5252
private static SignatureOutputStream certFileContents = null;
5353
private static byte[] buffer;
5454

55-
public static void signJar(File jarToSign, File outputJar, String alias,
55+
public static void signJarV1(File jarToSign, File outputJar, String alias,
5656
String keypass, String keystore, String storepass)
5757
throws GeneralSecurityException, IOException, NoSuchAlgorithmException {
5858

0 commit comments

Comments
 (0)