Skip to content

Commit 7f56ca5

Browse files
committed
remove key password from gradle.properties file after building bundle/package
1 parent 11865cd commit 7f56ca5

File tree

2 files changed

+22
-12
lines changed

2 files changed

+22
-12
lines changed

mode/src/processing/mode/android/AndroidBuild.java

Lines changed: 22 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ public File build(String target, String password) throws IOException, SketchExce
215215
this.target = target;
216216
File folder = createProject(true, password);
217217
if (folder == null) return null;
218-
if (!gradleBuild()) return null;
218+
if (!gradleBuildPackage()) return null;
219219
return folder;
220220
}
221221

@@ -291,11 +291,17 @@ protected boolean gradleBuildBundle() throws SketchException {
291291
connection.close();
292292
}
293293

294+
try {
295+
removeKeyPassword();
296+
} catch (IOException e) {
297+
e.printStackTrace();
298+
}
299+
294300
return success;
295301
}
296302

297303

298-
protected boolean gradleBuild() throws SketchException {
304+
protected boolean gradleBuildPackage() throws SketchException {
299305
ProjectConnection connection = GradleConnector.newConnector()
300306
.forProjectDirectory(tmpFolder)
301307
.connect();
@@ -330,6 +336,12 @@ protected boolean gradleBuild() throws SketchException {
330336
connection.close();
331337
}
332338

339+
try {
340+
removeKeyPassword();
341+
} catch (IOException e) {
342+
e.printStackTrace();
343+
}
344+
333345
return success;
334346
}
335347

@@ -353,9 +365,7 @@ private void createTopModule(String projectModules, String keyPassword)
353365
replaceMap.put("@@keystore_file@@", AndroidKeyStore.getKeyStore().getAbsolutePath());
354366
replaceMap.put("@@key_alias@@", AndroidKeyStore.ALIAS_STRING);
355367
replaceMap.put("@@key_password@@", keyPassword);
356-
357-
AndroidUtil.createFileFromTemplate(gradlePropsTemplate, gradlePropsFile, replaceMap);
358-
// Util.copyFile(gradlePropsTemplate, gradlePropsFile);
368+
AndroidUtil.createFileFromTemplate(gradlePropsTemplate, gradlePropsFile, replaceMap);
359369

360370
File settingsTemplate = mode.getContentFile("templates/" + GRADLE_SETTINGS_TEMPLATE);
361371
File settingsFile = new File(tmpFolder, "settings.gradle");
@@ -744,9 +754,6 @@ public File exportBundle(String keyStorePassword) throws Exception {
744754
File projectFolder = buildBundle("release", keyStorePassword);
745755
if (projectFolder == null) return null;
746756

747-
// File signedPackage = signPackage(projectFolder, keyStorePassword, "aab");
748-
// if (signedPackage == null) return null;
749-
750757
// Final export folder
751758
File exportFolder = createExportFolder("buildBundle");
752759
Util.copyDir(new File(projectFolder, getPathToAAB()), exportFolder);
@@ -762,9 +769,6 @@ public File exportPackage(String keyStorePassword) throws Exception {
762769
File projectFolder = build("release", keyStorePassword);
763770
if (projectFolder == null) return null;
764771

765-
// File signedPackage = signPackage(projectFolder, keyStorePassword, "apk");
766-
// if (signedPackage == null) return null;
767-
768772
// Final export folder
769773
File exportFolder = createExportFolder("buildPackage");
770774
Util.copyDir(new File(projectFolder, getPathToAPK()), exportFolder);
@@ -975,6 +979,13 @@ private void renameAPK() {
975979
}
976980
}
977981

982+
983+
private void removeKeyPassword() throws IOException {
984+
File gradlePropsTemplate = mode.getContentFile("templates/" + GRADLE_PROPERTIES_TEMPLATE);
985+
File gradlePropsFile = new File(tmpFolder, "gradle.properties");
986+
Util.copyFile(gradlePropsTemplate, gradlePropsFile);
987+
}
988+
978989

979990
private String getPathToAPK() {
980991
return module + "/build/outputs/apk/" + target + "/";

mode/src/processing/mode/android/AndroidEditor.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,6 @@ public void run() {
523523
try {
524524
File projectFolder = build.exportBundle(keyStorePassword);
525525
if (projectFolder != null) {
526-
527526
statusNotice(AndroidMode.getTextString("android_editor.status.bundle_export_completed"));
528527
Platform.openFolder(projectFolder);
529528
} else {

0 commit comments

Comments
 (0)