Skip to content

Commit b5b6d96

Browse files
committed
debugger updates
1 parent a1a1612 commit b5b6d96

File tree

5 files changed

+55
-24
lines changed

5 files changed

+55
-24
lines changed

mode/src/processing/mode/android/AndroidBuild.java

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -246,18 +246,21 @@ protected File createProject(boolean external)
246246
return tmpFolder;
247247
*/
248248

249+
249250
// build the preproc and get to work
250-
PdePreprocessor preproc = AndroidPreprocessorFactory.build(sketch.getName(), getPackageName());
251+
// PdePreprocessor preproc = AndroidPreprocessorFactory.build(sketch.getName(), getPackageName());
251252

252253
// On Android, this init will throw a SketchException if there's a problem with size()
253-
PreprocessorResult info = preproc.initSketchSize(sketch.getMainProgram());
254+
// PreprocessorResult info = preproc.initSketchSize(sketch.getMainProgram());
254255

255256
// SurfaceInfo info = preproc.initSketchSize(sketch.getMainProgram());
256257
// preproc.initSketchSmooth(sketch.getMainProgram());
257-
258-
sketchClassName = preprocess(srcFolder, getPackageName(), preproc, false);
258+
259+
PdePreprocessor preprocessor = PdePreprocessor.builderFor(sketch.getName()).build();
260+
sketchClassName = preprocess(srcFolder, getPackageName(), preprocessor, false);
259261
if (sketchClassName != null) {
260-
renderer = info.getSketchRenderer();
262+
// renderer = info.getSketchRenderer();
263+
renderer = "P2D";
261264
writeMainClass(srcFolder, renderer, external);
262265
createTopModule("':" + module +"'");
263266
createAppModule(module);

mode/src/processing/mode/android/AndroidDebugger.java

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import com.sun.jdi.request.EventRequestManager;
2828
import com.sun.jdi.request.StepRequest;
2929
import processing.app.Messages;
30-
import processing.mode.java.Debugger;
30+
import processing.mode.java.debug.Debugger;
3131
import processing.mode.java.debug.ClassLoadListener;
3232
import processing.mode.java.debug.LineBreakpoint;
3333
import processing.mode.java.debug.LineID;
@@ -222,6 +222,7 @@ public void run() {
222222
}
223223
}
224224

225+
/*
225226
@Override public synchronized void continueDebug() {
226227
editor.activateContinue();
227228
editor.variableInspector().lock();
@@ -234,9 +235,11 @@ public void run() {
234235
runtime.vm().resume();
235236
paused = false;
236237
editor.statusBusy();
237-
}
238+
}
238239
}
240+
*/
239241

242+
/*
240243
@Override protected void step(int stepDepth) {
241244
if (!isStarted()) {
242245
startDebug();
@@ -253,7 +256,9 @@ public void run() {
253256
editor.statusBusy();
254257
}
255258
}
259+
*/
256260

261+
/*
257262
@Override public synchronized void stopDebug() {
258263
editor.variableInspector().lock();
259264
if (runtime != null) {
@@ -278,6 +283,7 @@ public void run() {
278283
279284
editor.statusEmpty();
280285
}
286+
*/
281287

282288
/**
283289
* Watch all classes ({@value sketchClassName}) variable
@@ -317,7 +323,7 @@ LineBreakpoint breakpointOnLine(LineID line) {
317323
return null;
318324
}
319325

320-
synchronized void toggleBreakpoint(int lineIdx) {
326+
synchronized public void toggleBreakpoint(int lineIdx) {
321327
LineID line = editor.getLineIDInCurrentTab(lineIdx);
322328
int index = line.lineIdx();
323329
if (hasBreakpoint(line)) {
@@ -341,7 +347,7 @@ synchronized void setBreakpoint(int lineIdx) {
341347
setBreakpoint(editor.getLineIDInCurrentTab(lineIdx));
342348
}
343349

344-
synchronized void setBreakpoint(LineID line) {
350+
synchronized public void setBreakpoint(LineID line) {
345351
// do nothing if we are kinda busy
346352
if (isStarted() && !isPaused()) {
347353
return;

mode/src/processing/mode/android/AndroidEditor.java

Lines changed: 24 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424

2525
import processing.app.Base;
2626
import processing.app.Mode;
27+
import processing.app.Language;
2728
import processing.app.Platform;
2829
import processing.app.Settings;
2930
import processing.app.SketchException;
@@ -33,6 +34,7 @@
3334
import processing.app.ui.EditorToolbar;
3435
import processing.app.ui.Toolkit;
3536
import processing.mode.java.JavaEditor;
37+
import processing.mode.java.debug.Debugger;
3638
import processing.mode.java.debug.LineID;
3739
import processing.mode.java.preproc.PdePreprocessor;
3840

@@ -61,6 +63,7 @@ public class AndroidEditor extends JavaEditor {
6163

6264
private int appComponent;
6365

66+
protected JMenu debugMenu;
6467
private AndroidDebugger debugger;
6568

6669
private Settings settings;
@@ -90,10 +93,10 @@ protected AndroidEditor(Base base, String path, EditorState state,
9093
loadModeSettings();
9194
}
9295

93-
@Override
94-
public PdePreprocessor createPreprocessor(final String sketchName) {
95-
return new AndroidPreprocessor(sketchName);
96-
}
96+
// @Override
97+
// public PdePreprocessor createPreprocessor(final String sketchName) {
98+
// return new AndroidPreprocessor(sketchName);
99+
// }
97100

98101

99102
public EditorToolbar createToolbar() {
@@ -290,6 +293,12 @@ public void menuCanceled(MenuEvent e) {
290293
return androidMenu;
291294
}
292295

296+
private JMenu buildDebugMenu() {
297+
debugMenu = new JMenu(Language.text("menu.debug"));
298+
debugger.populateMenu(debugMenu);
299+
return debugMenu;
300+
}
301+
293302

294303
private void setAppComponent(int comp) {
295304
if (appComponent != comp) {
@@ -428,25 +437,28 @@ public AndroidDebugger getDebugger() {
428437
return debugger;
429438
}
430439

431-
@Override protected void deactivateDebug() {
432-
super.deactivateDebug();
433-
}
440+
441+
// @Override protected void deactivateDebug() {
442+
// super.deactivateDebug();
443+
// }
434444

435-
@Override protected void activateContinue() {
445+
@Override public void activateContinue() {
436446
((AndroidToolbar) toolbar).activateContinue();
437447
}
438448

439-
@Override protected void deactivateContinue() {
449+
@Override public void deactivateContinue() {
440450
((AndroidToolbar) toolbar).deactivateContinue();
441451
}
442452

443-
@Override protected void activateStep() {
453+
@Override public void activateStep() {
444454
((AndroidToolbar) toolbar).activateStep();
445455
}
446456

447-
@Override protected void deactivateStep() {
457+
@Override public void deactivateStep() {
448458
((AndroidToolbar) toolbar).deactivateStep();
449459
}
460+
461+
450462

451463
@Override
452464
public void toggleDebug() {
@@ -460,7 +472,7 @@ public void toggleBreakpoint(int lineIndex) {
460472
}
461473

462474
@Override
463-
protected LineID getCurrentLineID() {
475+
public LineID getCurrentLineID() {
464476
return super.getCurrentLineID();
465477
}
466478

mode/src/processing/mode/android/AndroidLineBreakpoint.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
package processing.mode.android;
2323

2424
import com.sun.jdi.ReferenceType;
25-
import processing.mode.java.Debugger;
25+
import processing.mode.java.debug.Debugger;
2626
import processing.mode.java.debug.LineBreakpoint;
2727
import processing.mode.java.debug.LineID;
2828

mode/src/processing/mode/android/AndroidToolbar.java

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ public void actionPerformed(ActionEvent e) {
156156
@Override
157157
public void actionPerformed(ActionEvent e) {
158158
final int mask = ActionEvent.SHIFT_MASK | ActionEvent.ALT_MASK;
159-
aEditor.handleStep(e.getModifiers() & mask);
159+
handleStep(e.getModifiers() & mask);
160160
}
161161
};
162162
toReturn.add(stepButton);
@@ -166,7 +166,7 @@ public void actionPerformed(ActionEvent e) {
166166
Language.text("menu.debug.continue")) {
167167
@Override
168168
public void actionPerformed(ActionEvent e) {
169-
aEditor.handleContinue();
169+
aEditor.getDebugger().continueDebug();
170170
}
171171
};
172172
toReturn.add(continueButton);
@@ -185,6 +185,16 @@ public void actionPerformed(ActionEvent e) {
185185
return toReturn;
186186
}
187187

188+
private void handleStep(int modifiers) {
189+
if (modifiers == 0) {
190+
aEditor.getDebugger().stepOver();
191+
} else if ((modifiers & ActionEvent.SHIFT_MASK) != 0) {
192+
aEditor.getDebugger().stepInto();
193+
} else if ((modifiers & ActionEvent.ALT_MASK) != 0) {
194+
aEditor.getDebugger().stepOut();
195+
}
196+
}
197+
188198
@Override
189199
public void addModeButtons(Box box, JLabel label) {
190200
EditorButton debugButton =

0 commit comments

Comments
 (0)