Skip to content

Commit f56048f

Browse files
committed
better algorithm of choosing width and height of the camera preview
Signed-off-by: Umair Khan <[email protected]>
1 parent 1df62ce commit f56048f

File tree

2 files changed

+24
-0
lines changed

2 files changed

+24
-0
lines changed

library/video_android.jar

271 Bytes
Binary file not shown.

src/in/omerjerk/processing/video/android/Capture.java

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ public class Capture extends VideoBase implements CameraHandlerCallback {
2727
private int selectedCamera = -1;
2828

2929
private CameraHandler mCameraHandler;
30+
31+
private boolean isPreviewSizeDefined = true;
3032

3133
public Capture(PApplet parent) {
3234
this(parent, -1, -1, null);
@@ -45,6 +47,7 @@ public Capture(PApplet parent, int width, int height, String cameraName) {
4547
if (width == -1 || height == -1) {
4648
width = 720;
4749
height = 1280;
50+
isPreviewSizeDefined = false;
4851
}
4952
init(width, height, ARGB);
5053
initalizeFrameBuffer();
@@ -225,6 +228,13 @@ public void startCamera(Integer cameraId) {
225228
try {
226229
log("Starting camera with camera id = " + cameraId);
227230
mCamera = Camera.open(cameraId);
231+
Camera.Parameters parameters = mCamera.getParameters();
232+
if (!isPreviewSizeDefined) {
233+
setPreviewSize(parameters, width);
234+
} else {
235+
parameters.setPreviewSize(width, height);
236+
}
237+
mCamera.setParameters(parameters);
228238
mCamera.setDisplayOrientation(90);
229239
} catch (Exception e) {
230240
System.err.println("Couldn't open the camera");
@@ -257,4 +267,18 @@ public void startPreview() {
257267
e.printStackTrace();
258268
}
259269
}
270+
271+
private void setPreviewSize(Camera.Parameters parameters, int expectedWidth) {
272+
List<Camera.Size> sizes = parameters.getSupportedPreviewSizes();
273+
int minDiff = 100000000;
274+
Camera.Size minSize = null;
275+
for (Camera.Size size : sizes) {
276+
if (minDiff > Math.abs(expectedWidth - size.width)) {
277+
minDiff = Math.abs(expectedWidth - size.width);
278+
minSize = size;
279+
}
280+
}
281+
Log.i("Capture", "Size not provided. Choosing " + minSize.width + "x" + minSize.height);
282+
parameters.setPreviewSize(minSize.width, minSize.height);
283+
}
260284
}

0 commit comments

Comments
 (0)