workaround for 2.x sketches that used Tweak Mode (fixes #415)

Author: benfry

app/src/processing/app/Base.java

@@ -1070,6 +1070,7 @@ private static ModeInfo modeInfoFor(final File sketch) {
   */
 
 
+  /*
   private Mode promptForMode(final File passedFile) {
     final String filename = passedFile.getName();
     final String extension =
@@ -1080,13 +1081,6 @@ private Mode promptForMode(final File passedFile) {
         possibleModes.add(mode);
       }
     }
-    /*
-    if (possibleModes.size() == 1 &&
-        possibleModes.get(0).getIdentifier().equals(getDefaultModeIdentifier())) {
-      // If default mode can open it, then do so without prompting.
-      return possibleModes.get(0);
-    }
-    */
     if (possibleModes.size() == 0) {
       final String msg =
         "I don't know how to open a sketch with the \"" + extension + "\"\n" +
@@ -1111,6 +1105,7 @@ private Mode promptForMode(final File passedFile) {
         null, modes, modes[0]);
     }
   }
+  */
 
 
   /*
@@ -1398,12 +1393,7 @@ private boolean smellsLikeSketchFolder(File folder) {
 
 
   private File moveLikeSketchFolder(File pdeFile, String baseName) throws IOException {
-//    final String properParent =
-//      file.getName().substring(0, file.getName().lastIndexOf('.'));
-
     Object[] options = {
-      //Language.text("prompt.ok"),
-      //Language.text("prompt.cancel")
       "Keep", "Move", "Cancel"
     };
     String prompt =
@@ -1494,14 +1484,27 @@ public Editor handleOpen(String path) {
         // First check for the Mode, because it may not even be available
         String modeIdentifier = props.get("mode.id");
         if (modeIdentifier != null) {
-          Mode mode = findMode(modeIdentifier);
-          if (mode != null) {
-            nextMode = mode;
+          if (modeIdentifier.equals("galsasson.mode.tweak.TweakMode")) {
+            // Tweak Mode has been built into Processing since 2015,
+            // but there are some old sketch.properties files out there.
+            // https://github.com/processing/processing4/issues/415
+            nextMode = getDefaultMode();
+
+            // Clean up sketch.properties and re-save or remove if necessary
+            props.remove("mode");
+            props.remove("mode.id");
+            props.reckon();
+
           } else {
-            ContributionManager.openModes();
-            Messages.showWarning("Missing Mode",
-              "You must first install " + props.get("mode") + " Mode to use this sketch.");
-            return null;
+            Mode mode = findMode(modeIdentifier);
+            if (mode != null) {
+              nextMode = mode;
+            } else {
+              ContributionManager.openModes();
+              Messages.showWarning("Missing Mode",
+                "You must first install " + props.get("mode") + " Mode to use this sketch.");
+              return null;
+            }
           }
         }
 

todo.txt

@@ -1,8 +1,8 @@
 1282 (4.0b7)
 X Bring back getMainProgram() for Python Mode
 X   https://github.com/processing/processing4/issues/409
-_ You must first install tweak Mode to use this sketch
-_   https://github.com/processing/processing4/issues/415
+X You must first install tweak Mode to use this sketch
+X   https://github.com/processing/processing4/issues/415
 
 _ deleting sketch removed contents of Download folder
 _   https://github.com/processing/processing4/issues/424