Skip to content

Commit 4153e4f

Browse files
committed
fix typo that displayed setNormal() instead of setAttrib() (fixes #141)
1 parent 4046950 commit 4153e4f

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

core/src/processing/opengl/PShapeOpenGL.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1757,7 +1757,7 @@ public void setNormal(int index, float nx, float ny, float nz) {
17571757
@Override
17581758
public void setAttrib(String name, int index, float... values) {
17591759
if (openShape) {
1760-
PGraphics.showWarning(INSIDE_BEGIN_END_ERROR, "setNormal()");
1760+
PGraphics.showWarning(INSIDE_BEGIN_END_ERROR, "setAttrib()");
17611761
return;
17621762
}
17631763

@@ -1774,7 +1774,7 @@ public void setAttrib(String name, int index, float... values) {
17741774
@Override
17751775
public void setAttrib(String name, int index, int... values) {
17761776
if (openShape) {
1777-
PGraphics.showWarning(INSIDE_BEGIN_END_ERROR, "setNormal()");
1777+
PGraphics.showWarning(INSIDE_BEGIN_END_ERROR, "setAttrib()");
17781778
return;
17791779
}
17801780

@@ -1791,7 +1791,7 @@ public void setAttrib(String name, int index, int... values) {
17911791
@Override
17921792
public void setAttrib(String name, int index, boolean... values) {
17931793
if (openShape) {
1794-
PGraphics.showWarning(INSIDE_BEGIN_END_ERROR, "setNormal()");
1794+
PGraphics.showWarning(INSIDE_BEGIN_END_ERROR, "setAttrib()");
17951795
return;
17961796
}
17971797

core/todo.txt

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
X loadJSONObject/Array() now return null if the given file was not found
33
X https://github.com/processing/processing/pull/6081
44
X remove zero width no-break space (U+FEFF) character with trim()
5+
X PShapeOpenGL setAttrib() warning says "setNormal()" instead of "setAttrib()"
6+
X https://github.com/processing/processing4/issues/141
57

68

79
fixed in 4.x (close/lock these with final 4.0 release)

0 commit comments

Comments
 (0)