Skip to content

Commit fac8a8e

Browse files
committed
confirmed that the new JOGL release fixes #124, removes workaround
1 parent 36263a0 commit fac8a8e

File tree

2 files changed

+4
-15
lines changed

2 files changed

+4
-15
lines changed

core/src/processing/opengl/PSurfaceJOGL.java

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -114,9 +114,6 @@ public class PSurfaceJOGL implements PSurface {
114114

115115
protected boolean external = false;
116116

117-
// Workaround for https://github.com/processing/processing4/issues/124
118-
static private boolean issue124 = PApplet.platform == PConstants.MACOS;
119-
120117

121118
public PSurfaceJOGL(PGraphics graphics) {
122119
this.graphics = graphics;
@@ -411,11 +408,7 @@ protected void initWindow() {
411408
window.setSurfaceScale(new float[] { surfaceScale, surfaceScale });
412409

413410
window.setSize(sketchWidth * windowScaleFactor, sketchHeight * windowScaleFactor);
414-
if (issue124) {
415-
window.setResizable(true);
416-
} else {
417-
window.setResizable(false);
418-
}
411+
window.setResizable(false);
419412
setSize(sketchWidth, sketchHeight);
420413
if (fullScreen) {
421414
PApplet.hideMenuBar();
@@ -956,11 +949,6 @@ public void display(GLAutoDrawable drawable) {
956949
pgl.endRender(sketch.sketchWindowColor());
957950
}
958951
PGraphicsOpenGL.completeFinishedPixelTransfers();
959-
960-
if (issue124) {
961-
setResizable(false);
962-
issue124 = false;
963-
}
964952
}
965953

966954
if (sketch.exitCalled()) {

core/todo.txt

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ X SVG Export
88
X update Batik to 1.13 (from 1.8)
99
X download it via direct link (don't check into repo)
1010
X fixes incompatibilities with org.w3c.dom and Java 11
11+
X JDK 11.0.7+ blank screen issue... workarounds/hacks in place, fix them:
12+
X https://github.com/processing/processing4/issues/124
13+
X fixed with the new JOGL RC
1114

1215
fixed in 4.x (close/lock these 3.x issues with final 4.0 release)
1316
_ AppKit errors from P2D/P3D
@@ -31,8 +34,6 @@ _ Linux: https://github.com/processing/processing/issues/5912
3134

3235
_ why does GL flash red when resizing?
3336

34-
_ JDK 11.0.7+ blank screen issue... workarounds/hacks in place, fix them:
35-
_ https://github.com/processing/processing4/issues/124
3637

3738
_ Skija bindings
3839
_ https://github.com/processing/processing4/issues/151

0 commit comments

Comments
 (0)