Skip to content

Commit d3fbefe

Browse files
committed
Revert "Define pkcs-9-at-extensionRequest to support Erlang/OTP 28 compilation (#3)"
This reverts commit ee5348a. The record was removed in OTP-28.0-rc4 and reintroduced in OTP-28.0.1 thanks to commit erlang/otp@b50e148
1 parent 27a5907 commit d3fbefe

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

src/p1_acme.erl

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -756,11 +756,6 @@ generate_key(ec) ->
756756
generate_key(rsa) ->
757757
public_key:generate_key({rsa, 2048, 65537}).
758758

759-
%% OTP-28.0-rc4 in commit b230e26c4f6530563919b19e76f2d2e96e436048
760-
%% removed in the file lib/public_key/asn1/PKCS-10.asn1
761-
%% several definitions. Let's add manually the macro here:
762-
-define('p1_acme-pkcs-9-at-extensionRequest', {1,2,840,113549,1,9,14}).
763-
764759
-spec generate_csr([domain(), ...], priv_key()) -> #'CertificationRequest'{}.
765760
generate_csr([_|_] = Domains, PrivKey) ->
766761
SignAlgoOID = signature_algorithm(PrivKey),
@@ -774,7 +769,7 @@ generate_csr([_|_] = Domains, PrivKey) ->
774769
critical = false,
775770
extnValue = DerSAN}],
776771
DerExtnReq = public_key:der_encode('ExtensionRequest', Extns),
777-
Attribute = #'AttributePKCS-10'{type = ?'p1_acme-pkcs-9-at-extensionRequest',
772+
Attribute = #'AttributePKCS-10'{type = ?'pkcs-9-at-extensionRequest',
778773
values = [{asn1_OPENTYPE, DerExtnReq}]},
779774
SubjPKInfo = #'CertificationRequestInfo_subjectPKInfo'{
780775
subjectPublicKey = subject_pubkey(PubKey),

0 commit comments

Comments
 (0)