Skip to content

Commit a6ac83b

Browse files
Adnuntius: Copy advertiserDomains to ORTB bid response adomain prebid#3736 (prebid#3740)
1 parent f2fa433 commit a6ac83b

File tree

4 files changed

+11
-22
lines changed

4 files changed

+11
-22
lines changed

src/main/java/org/prebid/server/bidder/adnuntius/AdnuntiusBidder.java

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,7 @@ private Bid createBid(AdnuntiusAd ad, BidRequest bidRequest, String adm, String
394394
.crid(ad.getCreativeId())
395395
.price(resolvePrice(ad, bidType))
396396
.adm(adm)
397-
.adomain(extractDomain(ad.getDestinationUrls()))
397+
.adomain(ad.getAdvertiserDomains())
398398
.ext(bidExt == null ? null : mapper.mapper().valueToTree(bidExt))
399399
.build();
400400
}
@@ -444,13 +444,4 @@ private static BigDecimal resolvePrice(AdnuntiusAd ad, String bidType) {
444444

445445
return amount != null ? amount.multiply(PRICE_MULTIPLIER) : BigDecimal.ZERO;
446446
}
447-
448-
private static List<String> extractDomain(Map<String, String> destinationUrls) {
449-
return destinationUrls == null ? Collections.emptyList() : destinationUrls.values().stream()
450-
.filter(Objects::nonNull)
451-
.map(url -> url.split("/"))
452-
.filter(splintedUrl -> splintedUrl.length >= 2)
453-
.map(splintedUrl -> StringUtils.replace(splintedUrl[2], "www.", ""))
454-
.toList();
455-
}
456447
}

src/main/java/org/prebid/server/bidder/adnuntius/model/response/AdnuntiusAd.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
import lombok.Builder;
55
import lombok.Value;
66

7+
import java.util.List;
78
import java.util.Map;
89

910
@Builder
@@ -41,5 +42,8 @@ public class AdnuntiusAd {
4142
@JsonProperty("destinationUrls")
4243
Map<String, String> destinationUrls;
4344

45+
@JsonProperty("advertiserDomains")
46+
List<String> advertiserDomains;
47+
4448
AdnuntiusAdvertiser advertiser;
4549
}

src/test/java/org/prebid/server/bidder/adnuntius/AdnuntiusBidderTest.java

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -751,9 +751,7 @@ public void makeBidsShouldReturnTwoBidFromDealsAndAdsWhenAdsAndDealsIsSpecified(
751751
.lineItemId("lineItemId")
752752
.dealId("dealId")
753753
.advertiser(AdnuntiusAdvertiser.of(null, "name"))
754-
.destinationUrls(Map.of(
755-
"key1", "https://www.domain1.com/uri",
756-
"key2", "http://www.domain2.dt/uri")))),
754+
.advertiserDomains(List.of("domain1.com", "domain2.dt")))),
757755
List.of(givenAd(ad -> ad
758756
.bid(AdnuntiusBid.of(BigDecimal.ONE, "USD"))
759757
.adId("adId")
@@ -762,9 +760,7 @@ public void makeBidsShouldReturnTwoBidFromDealsAndAdsWhenAdsAndDealsIsSpecified(
762760
.dealId("dealId")
763761
.html("dealHtml")
764762
.advertiser(AdnuntiusAdvertiser.of("legalName", "name"))
765-
.destinationUrls(Map.of(
766-
"key1", "https://www.domain1.com/uri",
767-
"key2", "http://www.domain2.dt/uri"))))));
763+
.advertiserDomains(List.of("domain1.com", "domain2.dt"))))));
768764

769765
final BidRequest bidRequest = givenBidRequest(givenImp(
770766
ExtImpAdnuntius.builder().auId("auId").build(), identity()));
@@ -900,9 +896,7 @@ public void makeBidsShouldReturnCorrectSeatBids() throws JsonProcessingException
900896
.creativeId("creativeId")
901897
.lineItemId("lineItemId")
902898
.dealId("dealId")
903-
.destinationUrls(Map.of(
904-
"key1", "https://www.domain1.com/uri",
905-
"key2", "http://www.domain2.dt/uri")))));
899+
.advertiserDomains(List.of("domain1.com", "domain2.dt")))));
906900

907901
final BidRequest bidRequest = givenBidRequest(
908902
givenImp(ExtImpAdnuntius.builder().auId("auId").build(), identity()));

src/test/resources/org/prebid/server/it/openrtb2/adnuntius/test-adnuntius-bid-response.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
"creativeId": "some_creative_id",
1717
"lineItemId": "some_line_item_id",
1818
"dealId": "some_deal_id",
19-
"destinationUrls": {
20-
"some_url": "https://www.domain.dm/uri"
21-
}
19+
"advertiserDomains": [
20+
"domain.dm"
21+
]
2222
}
2323
]
2424
}

0 commit comments

Comments
 (0)