Skip to content

Commit 20fce7f

Browse files
committed
Merge pull request #142 from progit/contributors-guide
Contributor's guide
2 parents d8b780c + 7b85439 commit 20fce7f

File tree

2 files changed

+39
-24
lines changed

2 files changed

+39
-24
lines changed

CONTRIBUTING.md

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
# Contributing to Pro Git (2nd Edition)
2+
3+
4+
## Licensing
5+
6+
By opening a pull request to this repository, you agree to provide your work under the [project license](LICENSE.asc).
7+
Also, you agree to grant such license of your work as is required for the purposes of future print editions to @ben and @schacon.
8+
Should your changes appear in a printed edition, you'll be included in the [contributors list](book/contributors.asc).
9+
10+
## Small Corrections
11+
12+
Errata and basic clarifications will be accepted if we agree that they improve the content. You can also open an issue so we can figure out how or if it needs to be addressed.
13+
14+
If you've never done this before, the [flow guide](https://guides.github.com/introduction/flow/) might be useful.
15+
16+
## Large Rewrites
17+
18+
Open an issue for discussion before you start. These changes tend to be very subjective, often only clarifying things for some small percentage of people and it's rarely worth the time to accept them. Professional copy editors have already reviewed this content multiple times so while you may have somewhat better taste and grammar than we do it's unlikely that your prose is going to be *so* much better that it's worth changing vast swaths of text.
19+
20+
## Figures
21+
22+
The images in this book were generated using [Sketch 3](http://bohemiancoding.com/sketch/), with the [included sketchbook file](diagram-source/progit.sketch).
23+
24+
To add a figure:
25+
26+
1. Add a page to the sketchbook. Try to use the included symbols wherever possible.
27+
1. Add a "slice" to your page. Give it a name that matches the destination PNG filename, relative from the root of the source directory.
28+
1. Make sure your slice is set to export at 3x size.
29+
30+
31+
## Translations
32+
33+
Translations to other languages are highly encouraged but handled a little differently than the first edition. We now keep each translation in a separate repository and automatically build the output files through Atlas. This was something that was really difficult in the last edition.
34+
35+
Since each translation is a different repository, we can also have different maintainers for each project. The Pro Git team simply pulls them in and builds them for the translation teams. To get automatic builds, translations repositories will have to be under the [`progit` organization on GitHub](https://github.com/progit).
36+
37+
You can find out information on all the current translations and information on how to start your own at http://progit.org/translations.

README.asc

Lines changed: 2 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -10,14 +10,6 @@ A couple of things have changed since open sourcing the first edition. For one,
1010

1111
We've also moved to keeping the translations in separate repositories rather than subdirectories of the English repository. See the Translations section for more information.
1212

13-
== Contributing
14-
15-
To contribute errata or new content to this repository, you will need to open up a Pull Request on GitHub. It is generally a good idea before doing anything major to open an issue and make sure your work will get accepted.
16-
17-
Errata and basic clarifications will be accepted if we agree that they improve the content. You can also open an issue so we can figure out how or if it needs to be addressed.
18-
19-
Please refrain from making sweeping copy edit changes as they tend to not get accepted and we don't want you wasting your time. These changes tend to be very subjective, often only clarifying things for some small percentage of people and it's rarely worth the time to accept them. Professional copy editors have already reviewed this content multiple times so while you may have somewhat better taste and grammar than we do it's unlikely that your prose is going to be *so* much better that it's worth changing vast swaths of text.
20-
2113
== How To Generate the Book
2214

2315
There are two ways to generate e-book content from this source code.
@@ -43,20 +35,6 @@ Converting to PDF...
4335

4436
This uses the `asciidoctor`, `asciidoctor-pdf` and `asciidoctor-epub` projects.
4537

46-
== Translations
47-
48-
Translations to other languages are highly encouraged but handled a little differently than the first edition. We now keep each translation in a separate repository and automatically build the output files through Atlas. This was something that was really difficult in the last edition.
49-
50-
Since each translation is a different repository, we can also have different maintainers for each project. The Pro Git team simply pulls them in and builds them for the translation teams. To get automatic builds, translations repositories will have to be under the https://github.com/progit[progit organization on GitHub].
51-
52-
You can find out information on all the current translations and information on how to start your own at: http://progit.org/translations[].
53-
54-
== Figures
55-
56-
The images in this book were generated using http://bohemiancoding.com/sketch/[Sketch 3], with the link:diagram-source/progit.sketch[included sketchbook file].
57-
58-
To add a figure:
38+
== Contributing
5939

60-
. Add a page to the sketchbook. Try to use the included symbols wherever possible.
61-
. Add a ``slice'' to your page. Give it a name that matches the destination PNG filename, relative from the root of the source directory.
62-
. Make sure your slice is set to export at 3x size.
40+
If you'd like to help out by making a change or contributing a translation, take a look at the link:CONTRIBUTING.md[contributor's guide].

0 commit comments

Comments
 (0)