Skip to content

Commit 3ad65c3

Browse files
committed
Clarify how updating pull requests works
Closes #374.
1 parent 9c6b460 commit 3ad65c3

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

book/06-github/sections/2-contributing.asc

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,9 +153,12 @@ Anyone can also leave general comments on the Pull Request. In <<_pr_discussion>
153153
.Pull Request discussion page
154154
image::images/blink-05-general-comment.png[PR discussion page]
155155

156-
Now the contributor can see what they need to do in order to get their change accepted. Luckily this is also a very simple thing to do. Where over email you may have to re-roll your series and resubmit it to the mailing list, with GitHub you simply commit to the topic branch again and push.
156+
Now the contributor can see what they need to do in order to get their change accepted.
157+
Luckily this is very straightforward.
158+
Where over email you may have to re-roll your series and resubmit it to the mailing list, with GitHub you simply commit to the topic branch again and push, which will automatically update the Pull Request.
159+
In <<_pr_final>> you can also see that the old code comment has been collapsed in the updated Pull Request, since it was made on a line that has since been changed.
157160

158-
If the contributor does that then the project owner will get notified again and when they visit the page they will see that it's been addressed. In fact, since a line of code changed that had a comment on it, GitHub notices that and collapses the outdated diff.
161+
Adding commits to an existing Pull Request doesn't trigger a notification, so once Tony has pushed his corrections he decides to leave a comment to inform the project owner that he made the requested change.
159162

160163
[[_pr_final]]
161164
.Pull Request final

0 commit comments

Comments
 (0)